otelcol: add telemetry.Factory to Factories#13950
Merged
Merged
Conversation
axw
force-pushed
the
otelcol-telemetryfactory
branch
from
9206919 to
2ef36a1
Compare
axw
commented
Oct 9, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13950 +/- ##
==========================================
+ Coverage 91.59% 91.63% +0.04%
==========================================
Files 655 655
Lines 42786 42789 +3
==========================================
+ Hits 39188 39209 +21
+ Misses 2772 2759 -13
+ Partials 826 821 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
axw
added a commit
to axw/opentelemetry-collector
that referenced
this pull request
Oct 9, 2025
Add a component for otelcol, and confighttp. The former is for open-telemetry#13950, while the latter is needed to fix .chloggen/13783.yaml.
This reverts commit 0f6f32f.
Contributor
Author
|
I need to make another fix to otelcoltest (I've broken datadogconnector tests), moving back to draft. |
Improve the coverage of TestConfigProvider* so it also covers the default telemetry provider code path. Tidy the TestConfigProvider* tests: - Just use a single confmap provider. They're both fakes, so testing one is enough. - Rather than comparing unmarshaled config to unmarshaled config, which is a bit circuitous, construct the expected config struct
axw
added a commit
to axw/opentelemetry-collector
that referenced
this pull request
Oct 9, 2025
Add a component for otelcol, e.g. for open-telemetry#13950
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 10, 2025
#### Description Add a component for otelcol for #13950 #### Link to tracking issue None #### Testing N/A #### Documentation N/A
mx-psi
reviewed
Oct 10, 2025
Keep the cmd/builder changes, but retain backwards compatibility in otelcol and otelcoltest to ease the transition in contrib.
Contributor
Author
|
contrib tests for exporter/alertmanager and exporter/dataset are failing due to unrelated changes in core |
mx-psi
reviewed
Oct 14, 2025
mx-psi
approved these changes
Oct 17, 2025
Member
mx-psi
left a comment
mx-psi
left a comment
There was a problem hiding this comment.
Will merge after Monday's release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a
TelemetryFactory telemetry.Factoryfield tootelcol.Factories. If it is nil, it will default to anotelconftelemetryfactory.This enables overriding telemetry providers.
Link to tracking issue
Fixes #4970
Testing
Documentation
N/A