Skip to content

[mdatagen] Set metrics' default stability to development#13870

Closed
ChrsMark wants to merge 1 commit intoopen-telemetry:mainfrom
ChrsMark:make_default_dev_metric_stblty
Closed

[mdatagen] Set metrics' default stability to development#13870
ChrsMark wants to merge 1 commit intoopen-telemetry:mainfrom
ChrsMark:make_default_dev_metric_stblty

Conversation

@ChrsMark
Copy link
Copy Markdown
Member

Description

Follow-up of #13756. Sets default metric's stability to development.

Link to tracking issue

Fixes #

Testing

Tuned

Documentation

~

@ChrsMark ChrsMark requested review from a team and dmitryax as code owners September 19, 2025 19:17
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 19, 2025

Codecov Report

❌ Patch coverage is 88.23529% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.37%. Comparing base (ba0b327) to head (f8fa649).
⚠️ Report is 122 commits behind head on main.

Files with missing lines Patch % Lines
cmd/mdatagen/internal/metric.go 50.00% 1 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (88.23%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13870   +/-   ##
=======================================
  Coverage   91.37%   91.37%           
=======================================
  Files         649      649           
  Lines       42653    42661    +8     
=======================================
+ Hits        38973    38981    +8     
  Misses       2854     2854           
  Partials      826      826           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Copy link
Copy Markdown
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest alpha as per the documentation https://opentelemetry.io/docs/collector/internal-telemetry/#telemetry-maturity-levels

Alternatively we could add development to that doc, but there's no guarantees with alpha

@ChrsMark
Copy link
Copy Markdown
Member Author

ChrsMark commented Sep 26, 2025

Moving this to draft since we are proceeding with setting explicitly all metrics in contrib for now: open-telemetry/opentelemetry-collector-contrib#42809

Next step, if we agree on this, is to make madatagen to require the stability field.

@github-actions
Copy link
Copy Markdown
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions Bot added the Stale label Oct 14, 2025
@ChrsMark
Copy link
Copy Markdown
Member Author

Closing this in honour of #14070

@ChrsMark ChrsMark closed this Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants