[internal/tools] Add support for modernize in Makefile#13800
Merged
Conversation
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13800 +/- ##
==========================================
- Coverage 91.43% 91.38% -0.05%
==========================================
Files 641 641
Lines 42670 42670
==========================================
- Hits 39016 38996 -20
- Misses 2835 2850 +15
- Partials 819 824 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
songy23
approved these changes
Sep 9, 2025
jmacd
approved these changes
Sep 9, 2025
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
Member
Author
codeboten
reviewed
Sep 10, 2025
Contributor
codeboten
left a comment
There was a problem hiding this comment.
this looks ok to me, do you have an example of what changes modernize proposes? i haven't used it before
Member
Author
|
@codeboten one PR example open-telemetry/opentelemetry-collector-contrib#42596 But you can find all the details here I'm not sure if this should be added to the CI, but maybe it should be something to evaluate in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a new modernize make target to run the Go modernize tool. This isn’t part of CI, users need to run it manually when they want to apply modern Go patterns.
Same as open-telemetry/opentelemetry-collector-contrib#42542