Skip to content

[internal/tools] Add support for modernize in Makefile#13800

Merged
codeboten merged 3 commits into
open-telemetry:mainfrom
paulojmdias:feat/go_modernize
Sep 11, 2025
Merged

[internal/tools] Add support for modernize in Makefile#13800
codeboten merged 3 commits into
open-telemetry:mainfrom
paulojmdias:feat/go_modernize

Conversation

@paulojmdias
Copy link
Copy Markdown
Member

Description

Added a new modernize make target to run the Go modernize tool. This isn’t part of CI, users need to run it manually when they want to apply modern Go patterns.

Same as open-telemetry/opentelemetry-collector-contrib#42542

Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
@paulojmdias paulojmdias requested a review from a team as a code owner September 9, 2025 13:14
@paulojmdias paulojmdias requested a review from dmathieu September 9, 2025 13:14
@github-actions github-actions Bot added the release:risky-change This change may affect the release label Sep 9, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.38%. Comparing base (62c505f) to head (25df519).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13800      +/-   ##
==========================================
- Coverage   91.43%   91.38%   -0.05%     
==========================================
  Files         641      641              
  Lines       42670    42670              
==========================================
- Hits        39016    38996      -20     
- Misses       2835     2850      +15     
- Partials      819      824       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@songy23 songy23 added ci-cd CI, CD, testing, build issues and removed release:risky-change This change may affect the release labels Sep 9, 2025
@github-actions github-actions Bot added the release:risky-change This change may affect the release label Sep 9, 2025
Signed-off-by: Paulo Dias <paulodias.gm@gmail.com>
@paulojmdias
Copy link
Copy Markdown
Member Author

paulojmdias commented Sep 9, 2025

@songy23 @jmacd I rebased the branch and ran make gotidy to fix the conflicts 🙏

Copy link
Copy Markdown
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks ok to me, do you have an example of what changes modernize proposes? i haven't used it before

@paulojmdias
Copy link
Copy Markdown
Member Author

@codeboten one PR example open-telemetry/opentelemetry-collector-contrib#42596

But you can find all the details here

I'm not sure if this should be added to the CI, but maybe it should be something to evaluate in the future.

Copy link
Copy Markdown
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @paulojmdias

@codeboten codeboten added this pull request to the merge queue Sep 11, 2025
Merged via the queue into open-telemetry:main with commit 4ba42b5 Sep 11, 2025
45 checks passed
@github-actions github-actions Bot added this to the next release milestone Sep 11, 2025
@paulojmdias paulojmdias deleted the feat/go_modernize branch September 11, 2025 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-cd CI, CD, testing, build issues release:risky-change This change may affect the release Skip Contrib Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants