[batchprocessor] Modernize the batch processor#13583
Closed
jmacd wants to merge 53 commits into
Closed
Conversation
…tor into jmacd/batch_block
…tor into jmacd/batch_block
…tor into jmacd/batch_deprec
jmacd
changed the title
…tor into jmacd/batch_deprec
…tor into jmacd/batch_deprec
iblancasa
approved these changes
Jan 26, 2026
…tor into jmacd/batch_deprec
…tor into jmacd/batch_deprec
…tor into jmacd/batch_deprec
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
…tor into jmacd/batch_deprec
…tor into jmacd/batch_deprec
jmacd
added
the
ready-to-merge
dmathieu
reviewed
Mar 30, 2026
| The number of batch processors currently in use is exported as the | ||
| `otelcol_processor_batch_metadata_cardinality` metric. | ||
|
|
||
| ## Modernization feature gates |
Member
There was a problem hiding this comment.
Could you configure the feature gates in metadata.yaml instead?
See https://github.com/open-telemetry/opentelemetry-collector/tree/main/featuregate#with-mdatagen
Member
|
Sorry, but this isn't ready to merge. It's lacking approvals by an approver+. |
dmathieu
removed
the
ready-to-merge
Member
|
During the face-to-face Collector SIG at KubeCon last week, an idea showed up of having component versions, e.g. |
Contributor
Author
|
Closing. This solution is close but cannot be merged. #15047 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements batchprocessor using exporterhelper features. Behind two feature flags:
processor.batch.useExporterHelper: use the new logic, QueueBatch withBlockOnOverflowprocessor.batch.propagateErrors: use error propagation viaWaitForResultThe use of feature flags is meant to acknowledge the fact that exporerhelper-based batching does not support every feature in the batch_processor component. After exporterhelper suppors
metadata_keys, we can move these feature flags forward and eventually remove the original implementation.Currently, this emits metrics with incorrect names; the batch processor emits metrics like an exporter, see #14038.
Link to tracking issue
Fixes #13582
Part of #13766
Part of #14038
Testing
Yes.
For every existing test case (19 cases), the test is run once with the feature and once without the feature. For a few selected tests, the propagateErrors feature is also tested.
4 tests are disabled in the exporterhelper-based mode because of the incorrect metric names.
Documentation
✅