[batchprocessor] Batch processor reimplemented with Exporterhelper#13547
Closed
jmacd wants to merge 24 commits into
Closed
[batchprocessor] Batch processor reimplemented with Exporterhelper#13547jmacd wants to merge 24 commits into
jmacd wants to merge 24 commits into
Conversation
…tor into jmacd/batch_block
…tor into jmacd/batch_block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part of #8122
This replaces the batchprocessor's legacy implementation with one based on exporterhelper.
Two featuregates are proposed:
useExporterHelper: use the exporterhelper-based implementationpropagateErrors: propagate errors from the batcher through to clientsNote the new implementation has been tested except for the metadata_keys-related support (#10825). The only problem here is that the component outputs exporter-like metrics, not legacy-like metrics. The failing tests are because of this detail. We could register metric views to rename exporterhelper metrics to processor metrics maybe, but that will be a little ugly and I would prefer to have an explicit metric-naming override.
Part of #13478: we need the batch-size metric which is used in existing tests by the batch processor.
Link to tracking issue
#8122 see also #10825
Testing
Yes [WIP]
Documentation
TODO