Fallback to content type in error handler#13413
Closed
delta003 wants to merge 2 commits into
Closed
Conversation
* Fallback to content type in error handler * This commit will be squashed.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the request lacks Content-Type, for whatever reason, the response is 500
{"code": 13, "message": "failed to marshal error message"}. In general, this shouldn't happen, but anything hitting a collector server wrongly results in 500 on a collector, which seems wrong (it's a client error).This is simple to repro:
curl -X GET localhost:4318with any auth extension returns 500. This is because auth extension returns an error that should propagate as 401, but because of error handling results in 500.Link to tracking issue
Testing
Documentation