[pdata/pprofile] remove field Profile.StartTime from pdata/pprofile #13315
Merged
Conversation
florianl
requested review from
a team,
bogdandrutu,
dmathieu,
dmitryax and
mx-psi
as code owners
….7.0 When working with pdata/pprofile I noticed, there is no field named StartTime in message Profile of the OTel Profiling signal in version v1.7.0 - see https://github.com/open-telemetry/opentelemetry-proto/blob/v1.7.0/opentelemetry/proto/profiles/v1development/profiles.proto. I also reordered the fields according to the OTel Profiling signal specification. Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
florianl
force-pushed
the
pprofile-align-signal
branch
from
dd21b3c to
5cf753f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13315 +/- ##
==========================================
- Coverage 91.50% 91.47% -0.03%
==========================================
Files 528 528
Lines 29475 29469 -6
==========================================
- Hits 26972 26958 -14
- Misses 1975 1981 +6
- Partials 528 530 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dmathieu
reviewed
Jul 2, 2025
Member
|
The field names need to be fixed in contrib first. Moving this to draft until that is done. |
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
florianl
changed the title
florianl
added a commit
to florianl/opentelemetry-collector-contrib
that referenced
this pull request
Jul 3, 2025
This is the supporting change for open-telemetry/opentelemetry-collector#13315 where Profile.StartTime gets removed. Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
florianl
added a commit
to florianl/opentelemetry-collector-contrib
that referenced
this pull request
Jul 3, 2025
This is the supporting change for open-telemetry/opentelemetry-collector#13315 where Profile.StartTime gets removed. Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
florianl
added a commit
to florianl/opentelemetry-collector-contrib
that referenced
this pull request
Jul 3, 2025
This is the supporting change for open-telemetry/opentelemetry-collector#13315 where Profile.StartTime gets removed. Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
bogdandrutu
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Jul 10, 2025
This is the supporting change for open-telemetry/opentelemetry-collector#13315 where Profile.StartTime gets removed. <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> --------- Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
dmathieu
approved these changes
Jul 10, 2025
mx-psi
reviewed
Jul 10, 2025
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
mx-psi
approved these changes
Jul 10, 2025
Merged
via the queue into
open-telemetry:main
with commit Jul 10, 2025
78fbbf6
53 of 56 checks passed
1 task
florianl
added a commit
to open-telemetry/opentelemetry-ebpf-profiler
that referenced
this pull request
Jul 15, 2025
With open-telemetry/opentelemetry-collector#13315 the duplicate field StartTime got removed upstream. Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
Dylan-M
pushed a commit
to Dylan-M/opentelemetry-collector-contrib
that referenced
this pull request
Aug 5, 2025
…y#41074) This is the supporting change for open-telemetry/opentelemetry-collector#13315 where Profile.StartTime gets removed. <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> --------- Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working with pdata/pprofile I noticed, there is no field named StartTime in message Profile of the OTel Profiling signal in version v1.7.0 - see https://github.com/open-telemetry/opentelemetry-proto/blob/v1.7.0/opentelemetry/proto/profiles/v1development/profiles.proto. I also reordered the fields according to the OTel Profiling signal specification.
Description
Link to tracking issue
Fixes #
Testing
Documentation