confighttp: make server span naming spec-compliant#13088
Merged
codeboten merged 2 commits intoMay 28, 2025
Conversation
Contributor
|
@axw this should be unblocked now that the deps update has been merged |
Update the confighttp server span names to use the low-cardnality request pattern, rather than the full client-specified path, as described by the specification.
e801c94 to
8b7e395
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13088 +/- ##
=======================================
Coverage 91.59% 91.60%
=======================================
Files 505 506 +1
Lines 28479 28544 +65
=======================================
+ Hits 26085 26147 +62
- Misses 1880 1882 +2
- Partials 514 515 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dmathieu
approved these changes
May 28, 2025
codeboten
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update the confighttp server span names to use the low-cardnality request pattern, rather than the full client-specified path, as described by the specification: https://opentelemetry.io/docs/specs/semconv/http/http-spans/#name.
Requires open-telemetry/opentelemetry-go-contrib#7192
Link to tracking issue
Fixes #12468
Testing
Added a unit test.
Documentation
None