confighttp: Ensure that auth errors use provided error handler#12714
Merged
mx-psi merged 7 commits intoApr 8, 2025
Conversation
…essage from auth extensions is included in the response
Contributor
Author
|
I noticed there may be a conflict with an existing PR #12702 , but I wanted to make sure that this issue was brought up before the refactoring, let me know if there are any further changes I need to make. |
jmacd
approved these changes
Mar 24, 2025
Contributor
jmacd
left a comment
There was a problem hiding this comment.
Yes, @bogdandrutu please take a look.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12714 +/- ##
==========================================
- Coverage 91.43% 91.42% -0.01%
==========================================
Files 487 487
Lines 26808 26811 +3
==========================================
+ Hits 24511 24512 +1
- Misses 1814 1815 +1
- Partials 483 484 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
iblancasa
approved these changes
Mar 28, 2025
codeboten
approved these changes
Apr 7, 2025
dmathieu
approved these changes
Apr 8, 2025
mx-psi
approved these changes
Apr 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OTLP/HTTP receiver does not encode authentication errors into a
Statusobject, and as such not expose a developer facing error message in theStatus.mesagefield. - https://opentelemetry.io/docs/specs/otlp/#failures-1Resolves this issue by handling authentication errors with the same error handler provided to the Server.
Link to tracking issue
Fixes #12666
Testing
Unit tests for handling errors with and without a server error handler