[extensionauth] Split extensionauth.Client by protocol type#12574
Merged
mx-psi merged 10 commits intoMar 12, 2025
Conversation
mx-psi
changed the title
bogdandrutu
reviewed
Mar 7, 2025
mx-psi
force-pushed
the
mx-psi/extensionauth-refactor
branch
from
5427cb5 to
9423499
Compare
mx-psi
force-pushed
the
mx-psi/extensionauth-refactor
branch
from
9423499 to
71bb798
Compare
mx-psi
changed the title
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #12574 +/- ##
==========================================
- Coverage 92.16% 92.06% -0.10%
==========================================
Files 471 473 +2
Lines 25561 25590 +29
==========================================
+ Hits 23558 23560 +2
- Misses 1591 1617 +26
- Partials 412 413 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bogdandrutu
reviewed
Mar 7, 2025
bogdandrutu
approved these changes
Mar 7, 2025
Member
bogdandrutu
left a comment
bogdandrutu
left a comment
There was a problem hiding this comment.
You will need to "undeprecate" the interface function implementations like https://github.com/open-telemetry/opentelemetry-collector/pull/12574/files#diff-23c4f67c72c9521b926d80da1f9233f3375e624222432f9983ae0aab05e8218aR64
bogdandrutu
added
the
release:blocker
jade-guiton-dd
approved these changes
Mar 11, 2025
Contributor
jade-guiton-dd
left a comment
jade-guiton-dd
left a comment
There was a problem hiding this comment.
LGTM, just a few nitpicks on the doc comments
Co-authored-by: Jade Guiton <jade.guiton@datadoghq.com>
Member
Author
|
I addressed all comments, however I do not want to merge this until the discussion over at #12601 is finalized |
Member
Author
|
Given #12601 (comment) I am going to merge this |
mx-psi
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Mar 12, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Prepares for addressing changes from open-telemetry/opentelemetry-collector#12574
mx-psi
added a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2025
…mentions (#38601) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> Follows #38451 and open-telemetry/opentelemetry-collector/pull/12574. Removes explicit mentions to `extensionauth.Client` and replaces them by `extensionauth.HTTPClient` and `extensionauth.GRPCClient`
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 19, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Removes deprecated symbols from `extensionauth` and `configauth` modules <!-- Issue number if applicable --> #### Link to tracking issue Follows #12574
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An attempt at splitting
extensionauth.Clientby protocol type. open-telemetry/opentelemetry-collector-contrib/pull/38451 removes usages of theNewClientandNewServerconstructor