Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Improve usage/setup of metadata.yaml #12343

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

bogdandrutu
Copy link
Member

Few miss-usages:

  1. Using a type like "receiver" when a simple "pkg" can be used, see "receiverhelper";
  2. Defining metadata.yaml without a generate statement, see "pdata";
  3. Legacy files that no longer need to be generated, see "exporterhelpe" the generated_status;
  4. Missing entry into the README.md to generate the documentation, see "pdata"

@bogdandrutu bogdandrutu requested review from a team and dmitryax as code owners February 11, 2025 04:49
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.53%. Comparing base (a4ae175) to head (ec45d9f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12343      +/-   ##
==========================================
+ Coverage   91.51%   91.53%   +0.01%     
==========================================
  Files         467      467              
  Lines       25623    25618       -5     
==========================================
  Hits        23450    23450              
+ Misses       1774     1769       -5     
  Partials      399      399              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pdata/metadata.yaml Show resolved Hide resolved
@bogdandrutu bogdandrutu force-pushed the improve-mdatagen-usage branch from b09ec27 to 301dfd6 Compare February 11, 2025 21:18
@songy23
Copy link
Member

songy23 commented Feb 12, 2025

needs make gotidy

@bogdandrutu bogdandrutu force-pushed the improve-mdatagen-usage branch from 8e9e25d to ec45d9f Compare February 13, 2025 17:27
@bogdandrutu bogdandrutu added this pull request to the merge queue Feb 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 13, 2025
@bogdandrutu bogdandrutu added this pull request to the merge queue Feb 13, 2025
Merged via the queue into open-telemetry:main with commit f51343b Feb 13, 2025
56 checks passed
@bogdandrutu bogdandrutu deleted the improve-mdatagen-usage branch February 13, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants