Skip to content

[chore] Fix componentattribute indirect refs#12330

Merged
mx-psi merged 1 commit into
open-telemetry:mainfrom
sincejune:fix-componentattribute-indirect-deps
Feb 10, 2025
Merged

[chore] Fix componentattribute indirect refs#12330
mx-psi merged 1 commit into
open-telemetry:mainfrom
sincejune:fix-componentattribute-indirect-deps

Conversation

@sincejune
Copy link
Copy Markdown
Contributor

Description

This PR added missing fixes for indirect refs of componentattributes, a follow-up PR of #12326

cc @bogdandrutu @codeboten @djaglowski @mx-psi

Link to tracking issue

n/a

Testing

n/a

Documentation

n/a

@sincejune sincejune requested a review from a team as a code owner February 10, 2025 11:58
@mx-psi
Copy link
Copy Markdown
Member

mx-psi commented Feb 10, 2025

Duplicate of #12329 ?

@sincejune
Copy link
Copy Markdown
Contributor Author

Duplicate of #12329 ?

Yes, I didn't notice your PR when I was raising this :(

@mx-psi
Copy link
Copy Markdown
Member

mx-psi commented Feb 10, 2025

No worries, we can merge this one :)


Semi-related topic, if you are interested in becoming an OpenTelemetry Github org member I would be happy to be one of your sponsors (see requirements here). Just reach out to me on the CNCF Slack (see my name on my GH profile) :)

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.39%. Comparing base (9a4f66a) to head (9bb9633).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12330   +/-   ##
=======================================
  Coverage   91.39%   91.39%           
=======================================
  Files         468      468           
  Lines       25598    25598           
=======================================
  Hits        23395    23395           
  Misses       1787     1787           
  Partials      416      416           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi mx-psi added this pull request to the merge queue Feb 10, 2025
Merged via the queue into open-telemetry:main with commit 44b3eed Feb 10, 2025
@sincejune sincejune deleted the fix-componentattribute-indirect-deps branch February 11, 2025 12:14
@sincejune
Copy link
Copy Markdown
Contributor Author

Semi-related topic, if you are interested in becoming an OpenTelemetry Github org member I would be happy to be one of your sponsors (see requirements here). Just reach out to me on the CNCF Slack (see my name on my GH profile) :)

@mx-psi Thank you so much! It would be my pleasure to be part of the OpenTelemetry community.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants