Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change queue to embed the consumers #12242

Merged
merged 1 commit into from
Feb 2, 2025

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Feb 2, 2025

This PR will facilitate:

  1. The implementation of the disabled queue, can be a simpler call into the "batcher" with the done callback setup and block until that is called.
  2. The implementation of the disabled batcher becomes trivial, and does not suffer from the limitation that only one reader of the queue is setup. Even though the request was sent async by multiple go-routines, still one reader which may have been a bottleneck.

In a separate PR will try to get rid of readableQueue. Initial version of the PR had "read" as a private func on Queue, but the "unused" linter complain that boundedMemoryQueue.read was unused.

Technically this is a breaking change, but Queue is an experimental API that we allow changes.

@bogdandrutu bogdandrutu requested review from dmitryax and a team as code owners February 2, 2025 06:45
@bogdandrutu bogdandrutu force-pushed the consumer-queue branch 3 times, most recently from 17bec6a to 5706f86 Compare February 2, 2025 07:09
Copy link

codecov bot commented Feb 2, 2025

Codecov Report

Attention: Patch coverage is 94.37500% with 9 lines in your changes missing coverage. Please review.

Project coverage is 91.30%. Comparing base (eb4f640) to head (27714cb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
exporter/exporterhelper/internal/queue_sender.go 62.50% 6 Missing and 3 partials ⚠️

❌ Your patch status has failed because the patch coverage (94.37%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12242      +/-   ##
==========================================
- Coverage   91.31%   91.30%   -0.02%     
==========================================
  Files         465      465              
  Lines       25677    25659      -18     
==========================================
- Hits        23448    23427      -21     
- Misses       1814     1816       +2     
- Partials      415      416       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@bogdandrutu bogdandrutu added this pull request to the merge queue Feb 2, 2025
Merged via the queue into open-telemetry:main with commit 7b878cf Feb 2, 2025
52 of 53 checks passed
@bogdandrutu bogdandrutu deleted the consumer-queue branch February 2, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants