[chore] Move exporter id attribute to the span #12164
Merged
+200
−185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12164 +/- ##
==========================================
+ Coverage 91.78% 91.82% +0.04%
==========================================
Files 462 463 +1
Lines 24893 24776 -117
==========================================
- Hits 22847 22750 -97
+ Misses 1664 1644 -20
Partials 382 382 ☔ View full report in Codecov by Sentry. |
dmitryax
approved these changes
Jan 22, 2025
dmitryax
reviewed
Jan 22, 2025
Signed-off-by: Bogdan Drutu <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 23, 2025
…ode (#12165) Depends on #12164 Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though we change the Span attributes, this is ok since tracing is still not stable.