Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd/mdatagen] Allow passing SDK metric options to SetupTelemetry #12160

Closed

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jan 22, 2025

Description

Allows passing sdkmetric.Options to SetupTelemetry. This is needed for removing usage of MetricsLevel on some tests in contrib such as https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/a151d166411c4e6e83324fff117d6fd49db751e8/exporter/prometheusremotewriteexporter/exporter_test.go#L743-L744

Link to tracking issue

Relates to #11061

@mx-psi mx-psi requested review from bogdandrutu, dmitryax and a team as code owners January 22, 2025 13:57
@mx-psi mx-psi force-pushed the mx-psi/setup-telemetry-options branch from 89cfc80 to 8e93263 Compare January 22, 2025 13:58
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 48 lines in your changes missing coverage. Please review.

Project coverage is 91.60%. Comparing base (461a355) to head (08c931a).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...r/internal/metadatatest/generated_telemetrytest.go 40.00% 5 Missing and 1 partial ⚠️
...r/internal/metadatatest/generated_telemetrytest.go 40.00% 5 Missing and 1 partial ⚠️
...r/internal/metadatatest/generated_telemetrytest.go 40.00% 5 Missing and 1 partial ⚠️
...r/internal/metadatatest/generated_telemetrytest.go 40.00% 5 Missing and 1 partial ⚠️
...r/internal/metadatatest/generated_telemetrytest.go 40.00% 5 Missing and 1 partial ⚠️
...r/internal/metadatatest/generated_telemetrytest.go 40.00% 5 Missing and 1 partial ⚠️
...r/internal/metadatatest/generated_telemetrytest.go 40.00% 5 Missing and 1 partial ⚠️
...e/internal/metadatatest/generated_telemetrytest.go 40.00% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12160      +/-   ##
==========================================
- Coverage   91.77%   91.60%   -0.18%     
==========================================
  Files         462      462              
  Lines       24886    24950      +64     
==========================================
+ Hits        22840    22856      +16     
- Misses       1664     1704      +40     
- Partials      382      390       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi mx-psi enabled auto-merge January 22, 2025 15:36
@bogdandrutu
Copy link
Member

bogdandrutu commented Jan 22, 2025

Please review #12151 first

@bogdandrutu
Copy link
Member

Same change, but applied on top of my PR #12166.

@mx-psi
Copy link
Member Author

mx-psi commented Jan 23, 2025

Closing in favor of #12166

@mx-psi mx-psi closed this Jan 23, 2025
auto-merge was automatically disabled January 23, 2025 10:54

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants