[exporter][batcher] Add the API ByteSize() to exporter.Request #12153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-sili
requested review from
bogdandrutu,
dmitryax and
a team
as code owners
sfc-gh-sili
force-pushed
the
sili-bytes-based-batching-pre
branch
from
cf461ca to
5d09bf6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12153 +/- ##
==========================================
- Coverage 91.73% 91.68% -0.05%
==========================================
Files 463 463
Lines 24819 24831 +12
==========================================
Hits 22767 22767
- Misses 1670 1682 +12
Partials 382 382 ☔ View full report in Codecov by Sentry. |
dmathieu
reviewed
Jan 22, 2025
| @@ -16,9 +16,10 @@ type Request interface { | |||
| // Export exports the request to an external endpoint. | |||
| Export(ctx context.Context) error | |||
| // ItemsCount returns a number of basic items in the request where item is the smallest piece of data that can be | |||
| // sent. For example, for OTLP exporter, this value represents the number of spans, | |||
| // metric data points or log records. | |||
| // sent. For example, for OTLP exporter, this value represents the number of spans, metric data points or log records. | |||
There was a problem hiding this comment.
This doc change isn't related to the purpose of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the API to
ByteSize()toexporter.RequestLink to tracking issue
#3262
Testing
Documentation