Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd/mdatagen] Remove dead field telemetry::level #12144

Merged

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jan 21, 2025

Description

Removes telemetry::level, which is unused. If this was intended to serve as the 'minimum level' for a component, I can handle that on #12143.

This is a breaking change, but since the field was effectively dead I think that's fine.

Link to tracking issue

Updates #11061

@mx-psi mx-psi marked this pull request as ready for review January 21, 2025 11:57
@mx-psi mx-psi requested a review from a team as a code owner January 21, 2025 11:57
@mx-psi mx-psi requested a review from atoulme January 21, 2025 11:57
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.72%. Comparing base (dcc866c) to head (e0f4eb8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12144   +/-   ##
=======================================
  Coverage   91.72%   91.72%           
=======================================
  Files         463      463           
  Lines       24821    24821           
=======================================
  Hits        22767    22767           
  Misses       1672     1672           
  Partials      382      382           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi mx-psi added this pull request to the merge queue Jan 21, 2025
Merged via the queue into open-telemetry:main with commit bc76c32 Jan 21, 2025
62 of 71 checks passed
@mx-psi mx-psi deleted the mx-psi/deprecate-metricslevel-toplevel branch January 21, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants