Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate CheckReceiverMetrics functions #12120

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

sincejune
Copy link
Contributor

Description

Deprecating CheckReceiverMetrics functions in the untested obsreporttest and otelchecker go files.

cc @bogdandrutu

Testing

n/a

Documentation

n/a

@sincejune sincejune requested a review from a team as a code owner January 18, 2025 08:23
@sincejune sincejune force-pushed the deprecate-checkreceivermetrics branch from 5583680 to dbea3be Compare January 18, 2025 08:36
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.85%. Comparing base (92c8136) to head (d155655).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #12120   +/-   ##
=======================================
  Coverage   91.85%   91.85%           
=======================================
  Files         465      465           
  Lines       25331    25331           
=======================================
  Hits        23267    23267           
  Misses       1675     1675           
  Partials      389      389           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sincejune sincejune force-pushed the deprecate-checkreceivermetrics branch 3 times, most recently from ed141cf to 2af0cce Compare January 18, 2025 14:57
@sincejune sincejune force-pushed the deprecate-checkreceivermetrics branch from 2af0cce to accc09a Compare January 18, 2025 15:08
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would do this later. I would for the moment move to the exporter metrics which are barely used in contrib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants