Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter][queuebatching] Implemented "DisabledQueue" which is used when batch is enabled but queue is disabled #12118

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sfc-gh-sili
Copy link
Contributor

@sfc-gh-sili sfc-gh-sili commented Jan 18, 2025

Description

This PR implements a component called "DisabledQueue".

Component Behavior
DisabledQueue Offer(req) blocks until the request is sent out
Blocking BoundedMemoryQueue Offer(req) blocks until there is space in the queue
Non Blocking BoundedMemoryQueue Offer(req) returns an error if the queue is full

DisabledQueue is used in place of PersistentStorageQueue or BoundedMemoryQueue when batching is enabled but queueing is disabled. Having this component enables us to have a unified implementation for the case when queueing is enabled or not.

Link to tracking issue

#8122
#10368

Testing

Documentation

@sfc-gh-sili sfc-gh-sili force-pushed the sili-batching branch 2 times, most recently from ff4a975 to c52e885 Compare January 18, 2025 01:11
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

Attention: Patch coverage is 91.22807% with 5 lines in your changes missing coverage. Please review.

Project coverage is 91.72%. Comparing base (fbefb22) to head (d38f666).

Files with missing lines Patch % Lines
exporter/exporterqueue/disabled_queue.go 86.11% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12118      +/-   ##
==========================================
- Coverage   91.73%   91.72%   -0.01%     
==========================================
  Files         463      464       +1     
  Lines       24819    24868      +49     
==========================================
+ Hits        22767    22811      +44     
- Misses       1670     1674       +4     
- Partials      382      383       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfc-gh-sili sfc-gh-sili force-pushed the sili-batching branch 2 times, most recently from 20a4b36 to 1b1ad11 Compare January 18, 2025 01:39
@sfc-gh-sili sfc-gh-sili marked this pull request as ready for review January 18, 2025 01:43
@sfc-gh-sili sfc-gh-sili requested review from bogdandrutu, dmitryax and a team as code owners January 18, 2025 01:43
@sfc-gh-sili sfc-gh-sili changed the title Implemented disabled queue [exporter][queuebatching] Implemented "DisabledQueue" which is used when batch is enabled but queue is disabled Jan 18, 2025
@jmacd
Copy link
Contributor

jmacd commented Jan 23, 2025

@sfc-gh-sili I read this PR trying to understand why when the queue sender is disabled, we have to create a "real" queue in some sense. For example, this PR you allocate a sizedQueue[disabledMemQueueEl[T]] as the stand-in for the batcher to use when there is no queueing. I would like a little documentation explaining how this works--or maybe put another way, why would we use the pull-based batcher if there is not a real queue? It would seem to make sense to continue with push-based batching if there is no queue, and I'm looking for a document that explains the current architecture and where we are headed so I can update #11948.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants