-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helper functions for printing flags #12094
base: main
Are you sure you want to change the base?
Conversation
|
Signed-off-by: cs-308-2023 <[email protected]>
Signed-off-by: cs-308-2023 <[email protected]>
@yurishkuro I have made the necessary changes. Following is how the output is coming: |
@@ -42,6 +42,11 @@ func NewCommand(set CollectorSettings) *cobra.Command { | |||
return rootCmd | |||
} | |||
|
|||
// Helper function for "make features" commmand for Jaeger | |||
func FeatureCommand(set CollectorSettings) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't follow. I am expecting to be able to run otelcol features
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, got it. Adding changes for the subcommand for otelcol features
.
I thought that only go run ./cmd/jaeger features
was required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am expecting to be able to run otelcol features
When I try to run otelcol features
, it is saying that otelcol is not a command. How to set up the command otelcol
and how to bind a function with features
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cd cmd/otelcorecol
go run . help
@ADI-ROXX you can copy and adapt implementation from jaegertracing/jaeger#6442 here |
on it |
Description
Beautifies and prints the feature flags
Link to tracking issue
Fixes #11998