Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper functions for printing flags #12094

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ADI-ROXX
Copy link

Description

Beautifies and prints the feature flags

Link to tracking issue

Fixes #11998

@ADI-ROXX ADI-ROXX requested a review from a team as a code owner January 15, 2025 09:26
@ADI-ROXX ADI-ROXX requested a review from bogdandrutu January 15, 2025 09:26
Copy link

linux-foundation-easycla bot commented Jan 15, 2025

CLA Not Signed

Signed-off-by: cs-308-2023 <[email protected]>
Signed-off-by: cs-308-2023 <[email protected]>
@ADI-ROXX
Copy link
Author

ADI-ROXX commented Jan 19, 2025

@yurishkuro I have made the necessary changes. Following is how the output is coming:
image

@@ -42,6 +42,11 @@ func NewCommand(set CollectorSettings) *cobra.Command {
return rootCmd
}

// Helper function for "make features" commmand for Jaeger
func FeatureCommand(set CollectorSettings) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't follow. I am expecting to be able to run otelcol features

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, got it. Adding changes for the subcommand for otelcol features.

I thought that only go run ./cmd/jaeger features was required.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am expecting to be able to run otelcol features

When I try to run otelcol features, it is saying that otelcol is not a command. How to set up the command otelcol and how to bind a function with features

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cd cmd/otelcorecol
go run . help

@yurishkuro
Copy link
Member

@ADI-ROXX you can copy and adapt implementation from jaegertracing/jaeger#6442 here

@ADI-ROXX
Copy link
Author

you can copy and adapt implementation from jaegertracing/jaeger#6442 here

on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "features" command to print documentation about all features
2 participants