Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove derprecated NewLogs[Request]Exporter funcs #11661

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu requested a review from a team as a code owner November 12, 2024 22:37
@bogdandrutu bogdandrutu force-pushed the rm-dep-exporterhelper branch from de0edfe to fbc9b27 Compare November 12, 2024 22:38
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.61%. Comparing base (164c28a) to head (8ff640a).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11661   +/-   ##
=======================================
  Coverage   91.61%   91.61%           
=======================================
  Files         440      440           
  Lines       23751    23751           
=======================================
  Hits        21759    21759           
  Misses       1621     1621           
  Partials      371      371           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu
Copy link
Member Author

@songy23 can you please fix datadog "datadog-agent/comp/otelcol/otlp/components/exporter/[email protected]"?

@songy23
Copy link
Member

songy23 commented Nov 12, 2024

open-telemetry/opentelemetry-collector-contrib#36345 fixes the contrib tests

mx-psi pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Nov 13, 2024
#### Description

This dep will be ignored in auto-udpate for now
#36339.

Fixes CI failures in core e.g
open-telemetry/opentelemetry-collector#11661
@bogdandrutu
Copy link
Member Author

@songy23

This comment was marked as outdated.

@bogdandrutu bogdandrutu merged commit 54adb32 into open-telemetry:main Nov 13, 2024
47 of 49 checks passed
@bogdandrutu bogdandrutu deleted the rm-dep-exporterhelper branch November 13, 2024 20:55
@github-actions github-actions bot added this to the next release milestone Nov 13, 2024
@songy23
Copy link
Member

songy23 commented Nov 13, 2024

NVM - the CI only fails in this PR because this PR does break a dependency in datadog exporter https://github.com/open-telemetry/opentelemetry-collector/actions/runs/11825085924/job/32948068600?pr=11661

will track this separately

bogdandrutu pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this pull request Nov 13, 2024
#### Description
Upgrade a dependency version to adopt a breaking change in
open-telemetry/opentelemetry-collector#11661
djaglowski pushed a commit to djaglowski/opentelemetry-collector that referenced this pull request Nov 21, 2024
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
#### Description

This dep will be ignored in auto-udpate for now
open-telemetry#36339.

Fixes CI failures in core e.g
open-telemetry/opentelemetry-collector#11661
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants