Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/scraperhelper] exit before scraping if the receiver was shutdown #11632

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Nov 8, 2024

Description

exit before scraping if the receiver was shutdown, do not wait the initial delay.

@atoulme atoulme requested a review from a team as a code owner November 8, 2024 23:34
@atoulme atoulme requested a review from codeboten November 8, 2024 23:34
@atoulme atoulme force-pushed the initial_delay_shutdown branch 2 times, most recently from 71c8ca3 to 8056e21 Compare November 8, 2024 23:37
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.58%. Comparing base (942f19a) to head (b8fceee).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11632      +/-   ##
==========================================
+ Coverage   91.53%   91.58%   +0.05%     
==========================================
  Files         441      440       -1     
  Lines       23922    23766     -156     
==========================================
- Hits        21896    21767     -129     
+ Misses       1650     1627      -23     
+ Partials      376      372       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atoulme atoulme force-pushed the initial_delay_shutdown branch from 8056e21 to b8fceee Compare November 8, 2024 23:45
@bogdandrutu bogdandrutu merged commit 6a276ba into open-telemetry:main Nov 12, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 12, 2024
@atoulme atoulme deleted the initial_delay_shutdown branch November 18, 2024 16:22
djaglowski pushed a commit to djaglowski/opentelemetry-collector that referenced this pull request Nov 21, 2024
…tdown (open-telemetry#11632)

#### Description
exit before scraping if the receiver was shutdown, do not wait the
initial delay.
@Makeuptehrani
Copy link

Description

exit before scraping if the receiver was shutdown, do not wait the initial delay.

HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
…tdown (open-telemetry#11632)

#### Description
exit before scraping if the receiver was shutdown, do not wait the
initial delay.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants