-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add profiles support to OTLP exporter #11435
Conversation
7e44499
to
fbe7524
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11435 +/- ##
==========================================
- Coverage 91.49% 91.48% -0.01%
==========================================
Files 433 433
Lines 23588 23617 +29
==========================================
+ Hits 21581 21607 +26
- Misses 1640 1642 +2
- Partials 367 368 +1 ☔ View full report in Codecov by Sentry. |
I merged #11226 :) |
fbe7524
to
01624de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @open-telemetry/collector-approvers I will merge this on Friday EU morning unless there are comments before then
@dmathieu Can you fix the merge conflict? |
Done! |
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This uses the profiles internal packages that were implemented in previous PRs to provide profiles support to the OTLP exporter. This PR requires open-telemetry#11226✅ to be merged first.
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This uses the profiles internal packages that were implemented in previous PRs to provide profiles support to the OTLP exporter. This PR requires open-telemetry#11226✅ to be merged first.
Description
This uses the profiles internal packages that were implemented in previous PRs to provide profiles support to the OTLP exporter.
This PR requires #11226✅ to be merged first.