[configgrpc] Remove deprecated aliases #11359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11359 +/- ##
==========================================
+ Coverage 91.52% 91.56% +0.03%
==========================================
Files 428 428
Lines 20233 20229 -4
==========================================
+ Hits 18519 18522 +3
+ Misses 1339 1333 -6
+ Partials 375 374 -1 ☔ View full report in Codecov by Sentry. |
mx-psi
approved these changes
Oct 4, 2024
jackgopack4
pushed a commit
to jackgopack4/opentelemetry-collector
that referenced
this pull request
Oct 8, 2024
#### Description This PR removes `ClientConfig.ToClientConnWithOptions`/`ServerConfig.ToServerWithOptions`, deprecated aliases of `ClientConfig.ToClientConn`/`ServerConfig.ToServer`, which were introduced in v0.111.0. This was part of the three step process to change the option type used by these methods (introduce new methods using the new option type and deprecate the old ones / remove old methods, rename new methods to the old names, add deprecated aliases for the new names / remove aliases). #### Link to tracking issue Fixes open-telemetry#9480
6 tasks
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
#### Description This PR removes `ClientConfig.ToClientConnWithOptions`/`ServerConfig.ToServerWithOptions`, deprecated aliases of `ClientConfig.ToClientConn`/`ServerConfig.ToServer`, which were introduced in v0.111.0. This was part of the three step process to change the option type used by these methods (introduce new methods using the new option type and deprecate the old ones / remove old methods, rename new methods to the old names, add deprecated aliases for the new names / remove aliases). #### Link to tracking issue Fixes open-telemetry#9480
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes
ClientConfig.ToClientConnWithOptions/ServerConfig.ToServerWithOptions, deprecated aliases ofClientConfig.ToClientConn/ServerConfig.ToServer, which were introduced in v0.111.0. This was part of the three step process to change the option type used by these methods (introduce new methods using the new option type and deprecate the old ones / remove old methods, rename new methods to the old names, add deprecated aliases for the new names / remove aliases).Link to tracking issue
Fixes #9480