Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default metrics address to localhost:8888 #11251

Merged

Conversation

bogdandrutu
Copy link
Member

No description provided.

@bogdandrutu bogdandrutu requested a review from a team as a code owner September 23, 2024 19:38
@bogdandrutu bogdandrutu force-pushed the change-prom-address-to-localhost branch from 6a37505 to 2e10422 Compare September 23, 2024 19:39
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@d6f568d). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11251   +/-   ##
=======================================
  Coverage        ?   91.54%           
=======================================
  Files           ?      424           
  Lines           ?    20190           
  Branches        ?        0           
=======================================
  Hits            ?    18482           
  Misses          ?     1324           
  Partials        ?      384           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu bogdandrutu force-pushed the change-prom-address-to-localhost branch 2 times, most recently from 581adab to 0fd8428 Compare September 23, 2024 20:13
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 this will make macos users' life easier

@bogdandrutu bogdandrutu force-pushed the change-prom-address-to-localhost branch from 0fd8428 to 03268e0 Compare September 25, 2024 20:39
@bogdandrutu bogdandrutu merged commit 1e29f99 into open-telemetry:main Sep 26, 2024
46 of 47 checks passed
@bogdandrutu bogdandrutu deleted the change-prom-address-to-localhost branch September 26, 2024 01:10
@github-actions github-actions bot added this to the next release milestone Sep 26, 2024
jackgopack4 pushed a commit to jackgopack4/opentelemetry-collector that referenced this pull request Oct 8, 2024
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants