-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default metrics address to localhost:8888 #11251
Merged
bogdandrutu
merged 1 commit into
open-telemetry:main
from
bogdandrutu:change-prom-address-to-localhost
Sep 26, 2024
Merged
Change default metrics address to localhost:8888 #11251
bogdandrutu
merged 1 commit into
open-telemetry:main
from
bogdandrutu:change-prom-address-to-localhost
Sep 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bogdandrutu
force-pushed
the
change-prom-address-to-localhost
branch
from
September 23, 2024 19:39
6a37505
to
2e10422
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11251 +/- ##
=======================================
Coverage ? 91.54%
=======================================
Files ? 424
Lines ? 20190
Branches ? 0
=======================================
Hits ? 18482
Misses ? 1324
Partials ? 384 ☔ View full report in Codecov by Sentry. |
bogdandrutu
force-pushed
the
change-prom-address-to-localhost
branch
2 times, most recently
from
September 23, 2024 20:13
581adab
to
0fd8428
Compare
songy23
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 this will make macos users' life easier
atoulme
reviewed
Sep 24, 2024
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
change-prom-address-to-localhost
branch
from
September 25, 2024 20:39
0fd8428
to
03268e0
Compare
dmitryax
approved these changes
Sep 25, 2024
jackgopack4
pushed a commit
to jackgopack4/opentelemetry-collector
that referenced
this pull request
Oct 8, 2024
Signed-off-by: Bogdan Drutu <[email protected]>
HongChenTW
pushed a commit
to HongChenTW/opentelemetry-collector
that referenced
this pull request
Dec 19, 2024
Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.