-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate service::telemetry::metrics::address #11205
Deprecate service::telemetry::metrics::address #11205
Conversation
d30111e
to
a6e00b6
Compare
8ac5f01
to
5bb7156
Compare
a401c44
to
b0f645c
Compare
c20a687
to
bd2798d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11205 +/- ##
=======================================
Coverage ? 91.56%
=======================================
Files ? 424
Lines ? 20195
Branches ? 0
=======================================
Hits ? 18492
Misses ? 1319
Partials ? 384 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Bogdan Drutu <[email protected]>
bd2798d
to
b26e22d
Compare
This is a much more verbose solution. Users would be wondering why are we doing it. Do we have an issue where we track the transition with the reasoning behind it? |
@dmitryax this was done in part to support the same configuration as is proposed by the opentelemetry-configuration schema, but also to support additional exporters, and more functionality like views in the future |
Co-authored-by: Alex Boten <[email protected]>
Existing configs like: ```yaml service: telemetry: metrics: level: "basic" address: "localhost:8888" ``` Should change to: ```yaml service: telemetry: metrics: level: "basic" readers: - pull: exporter: prometheus: host: "localhost" port: 8888 ``` --------- Signed-off-by: Bogdan Drutu <[email protected]> Co-authored-by: Alex Boten <[email protected]>
Existing configs like: ```yaml service: telemetry: metrics: level: "basic" address: "localhost:8888" ``` Should change to: ```yaml service: telemetry: metrics: level: "basic" readers: - pull: exporter: prometheus: host: "localhost" port: 8888 ``` --------- Signed-off-by: Bogdan Drutu <[email protected]> Co-authored-by: Alex Boten <[email protected]>
Existing configs like:
Should change to: