Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate service::telemetry::metrics::address #11205

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Sep 17, 2024

Existing configs like:

service:
  telemetry:
    metrics:
      level: "basic"
      address: "localhost:8888"

Should change to:

service:
  telemetry:
    metrics:
      level: "basic"
      readers:
        - pull:
            exporter:
              prometheus:
                host: "localhost"
                port: 8888

@bogdandrutu bogdandrutu requested review from a team and TylerHelmuth September 17, 2024 23:14
@bogdandrutu bogdandrutu requested a review from a team as a code owner September 18, 2024 18:40
@bogdandrutu bogdandrutu force-pushed the deprecate-address branch 2 times, most recently from 8ac5f01 to 5bb7156 Compare September 18, 2024 18:47
service/service_test.go Outdated Show resolved Hide resolved
service/telemetry/config.go Outdated Show resolved Hide resolved
service/telemetry/config.go Show resolved Hide resolved
service/telemetry/config.go Show resolved Hide resolved
@bogdandrutu bogdandrutu force-pushed the deprecate-address branch 2 times, most recently from a401c44 to b0f645c Compare September 19, 2024 17:51
@bogdandrutu bogdandrutu force-pushed the deprecate-address branch 5 times, most recently from c20a687 to bd2798d Compare September 23, 2024 19:06
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 86.48649% with 5 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@d6f568d). Learn more about missing BASE report.
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
service/telemetry/config.go 85.18% 2 Missing and 2 partials ⚠️
service/telemetry/metrics.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11205   +/-   ##
=======================================
  Coverage        ?   91.56%           
=======================================
  Files           ?      424           
  Lines           ?    20195           
  Branches        ?        0           
=======================================
  Hits            ?    18492           
  Misses          ?     1319           
  Partials        ?      384           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax
Copy link
Member

This is a much more verbose solution. Users would be wondering why are we doing it. Do we have an issue where we track the transition with the reasoning behind it?

@bogdandrutu
Copy link
Member Author

bogdandrutu commented Sep 24, 2024

This is a much more verbose solution. Users would be wondering why are we doing it. Do we have an issue where we track the transition with the reasoning behind it?

#7641
#7532

@codeboten
Copy link
Contributor

This is a much more verbose solution. Users would be wondering why are we doing it. Do we have an issue where we track the transition with the reasoning behind it?

@dmitryax this was done in part to support the same configuration as is proposed by the opentelemetry-configuration schema, but also to support additional exporters, and more functionality like views in the future

service/telemetry/config.go Outdated Show resolved Hide resolved
@bogdandrutu bogdandrutu merged commit 3eec76c into open-telemetry:main Sep 25, 2024
48 of 49 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 25, 2024
@bogdandrutu bogdandrutu deleted the deprecate-address branch September 26, 2024 17:57
jackgopack4 pushed a commit to jackgopack4/opentelemetry-collector that referenced this pull request Oct 8, 2024
Existing configs like:

```yaml
service:
  telemetry:
    metrics:
      level: "basic"
      address: "localhost:8888"
```

Should change to:

```yaml
service:
  telemetry:
    metrics:
      level: "basic"
      readers:
        - pull:
            exporter:
              prometheus:
                host: "localhost"
                port: 8888
```

---------

Signed-off-by: Bogdan Drutu <[email protected]>
Co-authored-by: Alex Boten <[email protected]>
HongChenTW pushed a commit to HongChenTW/opentelemetry-collector that referenced this pull request Dec 19, 2024
Existing configs like:

```yaml
service:
  telemetry:
    metrics:
      level: "basic"
      address: "localhost:8888"
```

Should change to:

```yaml
service:
  telemetry:
    metrics:
      level: "basic"
      readers:
        - pull:
            exporter:
              prometheus:
                host: "localhost"
                port: 8888
```

---------

Signed-off-by: Bogdan Drutu <[email protected]>
Co-authored-by: Alex Boten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants