Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the first argument of NewScraper component.Type #11159

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

mrasu
Copy link
Contributor

@mrasu mrasu commented Sep 12, 2024

Description

As a step of #9473, make the first argument of scraperhelper.NewScraper to take component.Type.

This PR deprecates NewScraperWithComponentType as the method is temporary and was created to change an argument of NewScraper

@mrasu mrasu marked this pull request as ready for review September 12, 2024 14:53
@mrasu mrasu requested review from a team and bogdandrutu September 12, 2024 14:53
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.32%. Comparing base (2166b11) to head (07c95f8).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
receiver/scraperhelper/scraper.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11159   +/-   ##
=======================================
  Coverage   92.32%   92.32%           
=======================================
  Files         413      413           
  Lines       19792    19792           
=======================================
  Hits        18273    18273           
  Misses       1149     1149           
  Partials      370      370           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bogdandrutu bogdandrutu merged commit e6cd56d into open-telemetry:main Sep 12, 2024
51 of 66 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 12, 2024
@mrasu mrasu deleted the replace-new-scraper branch September 14, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants