-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pprofile marshal/unmarshalling and gRPC implementations #11048
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11048 +/- ##
========================================
Coverage 92.23% 92.24%
========================================
Files 406 412 +6
Lines 19101 19554 +453
========================================
+ Hits 17618 18037 +419
- Misses 1123 1154 +31
- Partials 360 363 +3 ☔ View full report in Codecov by Sentry. |
63c3d85
to
a1205d5
Compare
d0e36d0
to
47932d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I can't see any users of this API according to this search https://github.com/search?q=-repo%3Aopen-telemetry%2Fopentelemetry-collector++go.opentelemetry.io%2Fcollector%2Fpdata%2Fpprofile+language%3AGo+-is%3Afork&type=code I think we can do this change in one step.
Description
This adds pprofile marshaling/unmarshaling, as well as the gRPC implementation, so we can start setup the OTLP receivers and exporters.