Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pprofile marshal/unmarshalling and gRPC implementations #11048

Merged
merged 16 commits into from
Sep 6, 2024

Conversation

dmathieu
Copy link
Member

@dmathieu dmathieu commented Sep 4, 2024

Description

This adds pprofile marshaling/unmarshaling, as well as the gRPC implementation, so we can start setup the OTLP receivers and exporters.

@dmathieu dmathieu changed the title Pprofile encoding and gRPC implementations Pprofile marshal/unmarshalling and gRPC implementations Sep 4, 2024
@dmathieu dmathieu marked this pull request as ready for review September 4, 2024 14:27
@dmathieu dmathieu requested review from a team and songy23 September 4, 2024 14:27
@songy23 songy23 requested a review from mx-psi September 4, 2024 14:32
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 92.73504% with 34 lines in your changes missing coverage. Please review.

Project coverage is 92.24%. Comparing base (46d0f73) to head (42bdfb1).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
pdata/pprofile/pprofileotlp/request.go 62.06% 9 Missing and 2 partials ⚠️
pdata/pprofile/pprofileotlp/response.go 76.92% 9 Missing ⚠️
pdata/pprofile/json.go 97.56% 8 Missing ⚠️
pdata/pprofile/pprofileotlp/grpc.go 78.94% 4 Missing ⚠️
pdata/internal/data/profileid.go 92.59% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #11048    +/-   ##
========================================
  Coverage   92.23%   92.24%            
========================================
  Files         406      412     +6     
  Lines       19101    19554   +453     
========================================
+ Hits        17618    18037   +419     
- Misses       1123     1154    +31     
- Partials      360      363     +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mx-psi mx-psi merged commit d19ebe4 into open-telemetry:main Sep 6, 2024
48 of 49 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants