Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for go1.23, bumped the minimum version to 1.22 #10869

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

codeboten
Copy link
Contributor

No description provided.

@codeboten codeboten requested review from a team and TylerHelmuth August 13, 2024 17:09
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codeboten
Copy link
Contributor Author

@songy23 opened a pr here: #10874

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.65%. Comparing base (23236b4) to head (dcf87b4).
Report is 2 commits behind head on main.

Files Patch % Lines
cmd/builder/internal/builder/main.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10869   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files         406      406           
  Lines       19035    19035           
=======================================
  Hits        17446    17446           
  Misses       1229     1229           
  Partials      360      360           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a 1.22.4 lurking in build-and-test-arm.yml. Also a

    "constraints": {
      "go": "1.21"
    },

in renovate.json

@codeboten codeboten merged commit 76acd37 into open-telemetry:main Aug 13, 2024
48 of 49 checks passed
@codeboten codeboten deleted the codeboten/go-1.23 branch August 13, 2024 21:32
@github-actions github-actions bot added this to the next release milestone Aug 13, 2024
codeboten added a commit that referenced this pull request Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants