Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][component] Document component.Host expectations #10720

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Jul 24, 2024

Description

Adds a note to the component.Host interface documenting that components may require additional interfaces.
I think this is the only sustainable pattern post 1.0, since we won't be able to add any new methods to the component.Host interface.

This pattern is also used today by:

Link to tracking issue

Fixes #10181

@mx-psi mx-psi requested review from a team, atoulme and TylerHelmuth July 24, 2024 10:21
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.24%. Comparing base (3caaf16) to head (6deb763).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10720   +/-   ##
=======================================
  Coverage   92.24%   92.24%           
=======================================
  Files         403      403           
  Lines       18720    18720           
=======================================
  Hits        17268    17268           
  Misses       1097     1097           
  Partials      355      355           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mx-psi mx-psi merged commit 192bfe3 into open-telemetry:main Jul 25, 2024
50 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[service] Define strategy for 'privileged' components
3 participants