Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[confighttp] Add NewDefault* functions for all config structs #9655

Closed
Tracked by #9508
TylerHelmuth opened this issue Feb 28, 2024 · 1 comment
Closed
Tracked by #9508

[confighttp] Add NewDefault* functions for all config structs #9655

TylerHelmuth opened this issue Feb 28, 2024 · 1 comment
Labels
area:config
Milestone
go.opentelemetry....

Comments

@TylerHelmuth
Copy link
Member

No description provided.

@TylerHelmuth TylerHelmuth mentioned this issue Feb 28, 2024
Closed
6 tasks
@Sanket-0510 Sanket-0510 mentioned this issue Mar 2, 2024
Closed
@TylerHelmuth TylerHelmuth moved this to In Progress in Collector: v1 Apr 18, 2024
@TylerHelmuth TylerHelmuth moved this from In Progress to Blocked in Collector: v1 Apr 18, 2024
@atoulme atoulme mentioned this issue May 31, 2024
Merged
@atoulme atoulme mentioned this issue Jul 20, 2024
Merged
mx-psi pushed a commit that referenced this issue Jul 22, 2024
@atoulme
[confighttp] add confighttp.NewDefaultServerConfig() (#10275)
0e14c22 
#### Description
add a new default method to instantiate the HTTP server config.

<!-- Issue number if applicable -->
#### Link to tracking issue
#9655
mx-psi pushed a commit that referenced this issue Aug 8, 2024
@atoulme
[confighttp] Add NewDefaultCORSConfig function (#10676)
00d9d72 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Add `NewDefaultCORSConfig` function to initialize the default
`confighttp.CORSConfig`

<!-- Issue number if applicable -->
#### Link to tracking issue
#9655
@atoulme
Copy link
Contributor

atoulme commented Aug 28, 2024

I think we covered most if not all functions, and we can add to the API later. We should close as done for now.

@github-project-automation github-project-automation bot moved this from Blocked to Done in Collector: v1 Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:config
Projects
Collector: v1
Archived in project
Milestone
go.opentelemetry.io/collector/configh...
Development

Successfully merging a pull request may close this issue.

[confighttp] newDefault for confighttp package structs Sanket-0510/opentelemetry-collector
2 participants
@atoulme @TylerHelmuth