[component] Add support for components specifying what instruments to enable depending on metric level #11754
Assignees
Labels
enhancement
New feature or request
Comments
This was referenced Jan 21, 2025
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 22, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number if applicable --> Drops metrics that depend on the metrics level: - Batch processor metric - otelarrow metrics (see open-telemetry/otel-arrow/issues/280 for limitation). - internal/otelarrow/netstats metrics. I did not implement https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/a25f058256e8339e49e4c89ac622a9ef47b52334/internal/otelarrow/netstats/netstats.go#L133-L136 since `LevelNone` drops all metrics. This attemps to unblock #11601 by hardcoding the metrics here since there is a small number of them. Once we do #11754 we can move this back to the individual components #### Link to tracking issue Updates #11061
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 22, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number if applicable --> Removes `level` field. This will be added back in the future once #11754 is completed. #### Link to tracking issue Updates #11061
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After doing #11061, we still need a way for components that make use of
service::telemetry::metrics::levelto specify what instruments are enabled at which level (or figure out how to use this exactly).We need this at SDK creation time so this would probably be factory option.
If we want to sidestep this issue, we could hardcode things for the components that use this (batch processor, configgrpc, confighttp, otelarrow) instead.
cc @bogdandrutu
The text was updated successfully, but these errors were encountered: