-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Split core and contrib workflows #477
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
requested review from
a team,
djaglowski,
jpkrohling and
codeboten
February 14, 2024 22:52
Created #478 to take care of ensuring |
jpkrohling
reviewed
Feb 15, 2024
TylerHelmuth
force-pushed
the
main
branch
2 times, most recently
from
February 15, 2024 18:00
e2d687d
to
2b4b5e4
Compare
jpkrohling
reviewed
Feb 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks mostly right, but there are a few cosign-related changes that seem misplaced.
@jpkrohling all those downgrades were the result of a bad merge. Should now be fixed. |
jpkrohling
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the Core and Contrib distributions into separate workflows.
The repository continues to use a single goreleaser.yaml file because:
We specifically take advantage of
id
to specify exactly which things in the goreleaser.yaml file get built.For now I did not change the triggers - both sets of workflows will currently always be triggered at the same time, like they are today.
Related to #429
Example workflows:
I couldn't test the actual release bc I don't have a goreleaser-pro key.