Add debug flag to print metrics payload and sketches payload#8929
Merged
Conversation
mx-psi
reviewed
Mar 28, 2022
Member
mx-psi
left a comment
mx-psi
left a comment
There was a problem hiding this comment.
Thanks for taking the time to address the suggestions 🙇 🙇
This looks good, we just need the CI checks to pass. Right now you are missing two things for CI to pass:
- Add a changelog entry on
CHANGELOG.md - Amend your commits so that they have a valid email and user
kmotupalli-tc
force-pushed
the
add-debug-flag
branch
from
591e5a7 to
e0a45e2
Compare
mx-psi
approved these changes
Mar 29, 2022
mx-psi
added
the
ready to merge
Member
|
I have marked this as 'ready to merge', a maintainer will have a final look and merge it in the next few days :) |
codeboten
approved these changes
Mar 29, 2022
pmm-sumo
approved these changes
Mar 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Added debug logging to log metrics payload data and sketches payload data sent to Datadog. Redo #5856 as debug log instead of Info log. Metrics payload data and sketches payload data will be logged if collector is started in debug mode.
Link to tracking Issue: #7528
Testing: Started the collector in debug mode to test the output. The metrics payload data and sketches payload only logged if the collector is in debug mode.