Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[k8sattributes processor] Add container metadata #5467

Merged

Conversation

dmitryax
Copy link
Member

@dmitryax dmitryax commented Sep 28, 2021

Description:

This change provides an option to fetch container metadata from k8s API in addition to k8s pod metadata. The following attributes now can be automatically added by the k8sattributes processor:

  • container.image.name
  • container.image.tag
  • container.id

container.image.name and container.image.tag require additional container identifier present in resource attributes: container.name.

container.id requires additional container run identifiers present in resource attributes: container.name and run_id.

run_id identified is a subject to change, see open-telemetry/opentelemetry-specification#1945

Link to tracking Issue: #5235

Testing: Unit tests + manual validation

Documentation: Added docs

@dmitryax dmitryax requested review from owais and a team September 28, 2021 07:28
This change provides an option to fetch container metadata from k8s API in addition to k8s pod metadata. The following attributes now can be automatically added by the k8sattributes processor:
- container.image.name
- container.image.tag
- container.id

`container.image.name` and `container.image.tag` require additional container identifier present in resource attributes: `container.name`.

`container.id` requires additional container run identifiers present in resource attributes: `container.name` and `run_id`.

`run_id` identified is a subject to change, see open-telemetry/opentelemetry-specification#1945
@dmitryax dmitryax force-pushed the k8sattribute-contaner-metadata branch from a6cfbc1 to 12dc403 Compare September 28, 2021 07:56
@dmitryax dmitryax changed the title [k8sattributes processor] Add optional container metadata [k8sattributes processor] Add container metadata Sep 28, 2021
@bogdandrutu bogdandrutu merged commit f048c51 into open-telemetry:main Sep 28, 2021
dmitryax referenced this pull request in dmitryax/opentelemetry-collector-contrib Sep 29, 2021
bogdandrutu pushed a commit that referenced this pull request Sep 29, 2021
@dmitryax dmitryax deleted the k8sattribute-contaner-metadata branch September 29, 2021 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants