receiver/prometheus: roundtrip Prometheus->Pdata direct conversion without OpenCensus#5184
Closed
odeke-em wants to merge 4 commits into
Closed
receiver/prometheus: roundtrip Prometheus->Pdata direct conversion without OpenCensus#5184odeke-em wants to merge 4 commits into
odeke-em wants to merge 4 commits into
Conversation
odeke-em
force-pushed
the
receiver-prometheus-wireUp-roundTrip
branch
from
26d4c51 to
860cb7f
Compare
odeke-em
force-pushed
the
receiver-prometheus-wireUp-roundTrip
branch
4 times, most recently
from
36a0016 to
4aa5666
Compare
Member
|
Please fix lint and unittests |
odeke-em
referenced
this pull request
in orijtech/opentelemetry-collector-contrib
Sep 13, 2021
This change updates internal code and is meant to alleviate the massive PR #5184 which is our eventual end-goal. No need for tests because the code path isn't used so we have a license to update it towards the end goal. Particularly it: * adds open-telemetry/opentelemetry-collector#3116 to the otlp version. * copies the sortPoints method over verbatim. * sets DataType and Name on pdata metrics. Updates PR #5184
odeke-em
force-pushed
the
receiver-prometheus-wireUp-roundTrip
branch
5 times, most recently
from
c0cd01f to
0df490c
Compare
odeke-em
referenced
this pull request
in orijtech/opentelemetry-collector-contrib
Sep 13, 2021
Adds helper functions to help create metrics for OTLP pdata translations. The need for these helpers comes from PR #5184 in which we need to translate directly from Prometheus->Pdata instead of Prometheus->OpenCensus->Pdata, but we shall need to modify both receiver/prometheus*/internal and the base directory. This code is heavily used in the mentioned PR and thus no tests included in this change. Updates PR #5184
odeke-em
force-pushed
the
receiver-prometheus-wireUp-roundTrip
branch
4 times, most recently
from
6bb6f7d to
c8b9757
Compare
…thout OpenCensus Wire up and use the direct Prometheus->Pdata conversion end to end. With this change the receiver will no longer need OpenCensus. This change will involve more follow-ups that just migrate over the tests, because we don't want a super bloated/massive PR. Fixes #4892 Depends on PR open-telemetry/opentelemetry-collector#3694 Depends on PR open-telemetry/opentelemetry-collector#3695
odeke-em
force-pushed
the
receiver-prometheus-wireUp-roundTrip
branch
2 times, most recently
from
6ac1d06 to
9605687
Compare
odeke-em
force-pushed
the
receiver-prometheus-wireUp-roundTrip
branch
from
9605687 to
de159f6
Compare
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Member
|
Closing this PR as inactive, since the feedback was not addressed for more than 1m. |
hex1848
pushed a commit
to hex1848/opentelemetry-collector-contrib
that referenced
this pull request
Jun 2, 2022
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire up and use the direct Prometheus->Pdata conversion end to end.
With this change the receiver will no longer need OpenCensus.
This change will involve more follow-ups that just migrate over the tests,
because we don't want a super bloated/massive PR.
Fixes #4892
Depends on PR open-telemetry/opentelemetry-collector#3694
Depends on PR open-telemetry/opentelemetry-collector#3695