Skip to content

[chore] (pkg/ottl) migrate feature gates to metadata.yaml#48240

Merged
edmocosta merged 2 commits into
open-telemetry:mainfrom
agarvin-nr:agarvin/migrate-ottl-pkg-feature-gates
May 12, 2026
Merged

[chore] (pkg/ottl) migrate feature gates to metadata.yaml#48240
edmocosta merged 2 commits into
open-telemetry:mainfrom
agarvin-nr:agarvin/migrate-ottl-pkg-feature-gates

Conversation

@agarvin-nr
Copy link
Copy Markdown
Contributor

@agarvin-nr agarvin-nr commented May 8, 2026

Description

  • Migrates pkg/ottl feature gates to metadata.yaml:
    • ottl.PanicDuplicateName
    • ottl.contexts.enableOtelColContext
  • Removes manual feature gate migration
  • Updates ottl.PanicDuplicateName with 'from' version and reference URL
  • Generates metadata, gci
  • Removes forbidigo linter exclusion from pgk/ottl

Link to tracking issue

Part of #46116

Testing

make test and make lint

@agarvin-nr agarvin-nr force-pushed the agarvin/migrate-ottl-pkg-feature-gates branch from 749b459 to 0d9fff3 Compare May 8, 2026 20:51
@agarvin-nr agarvin-nr marked this pull request as ready for review May 8, 2026 20:52
Copy link
Copy Markdown
Contributor

@edmocosta edmocosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@edmocosta edmocosta merged commit 05b836e into open-telemetry:main May 12, 2026
216 checks passed
@otelbot
Copy link
Copy Markdown
Contributor

otelbot Bot commented May 12, 2026

Thank you for your contribution @agarvin-nr! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help.

mx-psi pushed a commit that referenced this pull request May 19, 2026
)

#### Description

Migrate the `exporter.signalfx.consumeEntityEvents` feature gate to be
declared in `metadata.yaml` and code-generated via `mdatagen`, matching
the convention enforced by the `forbidigo` linter introduced in #47506.

This continues the work tracked in #46116, following the same pattern as
recent migrations (#48066, #48240, #48281, #47893).

No behavior change for users: the feature gate ID, stage, description,
and `from_version` are preserved exactly. A `reference_url` was added
pointing to the PR that introduced the gate (#45595), which is required
by mdatagen.

#### Link to tracking issue

Updates #46116

#### Testing

From `exporter/signalfxexporter`:
- `make mdatagen` — clean re-generation, no diff after `make fmt && make
gci`.
- `go build ./...` — passes.
- `go test ./... -count=1` — passes.
- `golangci-lint run --config=<repo>/.golangci.yml ./...` (v2.7) —
clean.

#### Documentation

`documentation.md` is now generated from `metadata.yaml` and lists the
feature gate.

Signed-off-by: iahsanGill <mgill.bese22seecs@seecs.edu.pk>
ben-trans pushed a commit to ben-trans/opentelemetry-collector-contrib that referenced this pull request May 25, 2026
…n-telemetry#48466)

#### Description

Migrate the `exporter.signalfx.consumeEntityEvents` feature gate to be
declared in `metadata.yaml` and code-generated via `mdatagen`, matching
the convention enforced by the `forbidigo` linter introduced in open-telemetry#47506.

This continues the work tracked in open-telemetry#46116, following the same pattern as
recent migrations (open-telemetry#48066, open-telemetry#48240, open-telemetry#48281, open-telemetry#47893).

No behavior change for users: the feature gate ID, stage, description,
and `from_version` are preserved exactly. A `reference_url` was added
pointing to the PR that introduced the gate (open-telemetry#45595), which is required
by mdatagen.

#### Link to tracking issue

Updates open-telemetry#46116

#### Testing

From `exporter/signalfxexporter`:
- `make mdatagen` — clean re-generation, no diff after `make fmt && make
gci`.
- `go build ./...` — passes.
- `go test ./... -count=1` — passes.
- `golangci-lint run --config=<repo>/.golangci.yml ./...` (v2.7) —
clean.

#### Documentation

`documentation.md` is now generated from `metadata.yaml` and lists the
feature gate.

Signed-off-by: iahsanGill <mgill.bese22seecs@seecs.edu.pk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants