[chore] processor/metricsgenerationprocessor: migrate feature gate to mdatagen#47512
Merged
Conversation
github-actions
Bot
added
the
processor/metricsgeneration
Contributor
|
Thanks ! for working on this a few cl checks are currently failing
|
ogulcanaydogan
added a commit
to ogulcanaydogan/opentelemetry-collector-contrib
that referenced
this pull request
Apr 10, 2026
Add .chloggen entry for PR open-telemetry#47512 and fix import ordering in generated_package_test.go per make gogci.
Contributor
Author
|
Thanks for the feedback @jijo-OO7! I've pushed a follow-up commit that:
|
Move metricsgeneration.MatchAttributes feature gate registration from manual featuregate.GlobalRegistry().MustRegister() in processor.go to the metadata.yaml file, letting mdatagen generate the registration code. Remove the forbidigo lint exclusion for this package from .golangci.yml since it no longer uses manual feature gate registration. Fixes open-telemetry#46116
Add .chloggen entry for PR open-telemetry#47512 and fix import ordering in generated_package_test.go per make gogci.
…runs The package-level testCases slice holds pre-built pmetric.Metrics objects. The processor appends new metrics in-place, so subsequent runs under -count=3 see a progressively growing inMetrics, causing expected:3 actual:5 failures. Assisted-by: Claude Sonnet 4.6
pmetric.Metrics has no Clone method; use NewMetrics + CopyTo instead. Assisted-by: Claude Sonnet 4.6
ogulcanaydogan
force-pushed
the
refactor/46116-migrate-featuregate-metricsgenerationprocessor
branch
from
eaaae3e to
4084a68
Compare
mx-psi
reviewed
Apr 10, 2026
mx-psi
left a comment
mx-psi
left a comment
Member
There was a problem hiding this comment.
Just one note about the changelog, otherwise looks good!
Member
There was a problem hiding this comment.
I think we don't need a changelog entry for this, as @jijo-OO7 suggested, could you remove this and add "[chore]" at the start of your PR name?
Contributor
Author
There was a problem hiding this comment.
Done — removed the changelog file and updated the PR title to [chore].
ogulcanaydogan
changed the title
mx-psi
approved these changes
Apr 10, 2026
Contributor
|
Thank you for your contribution @ogulcanaydogan! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help. |
ogulcanaydogan
added a commit
to ogulcanaydogan/opentelemetry-collector-contrib
that referenced
this pull request
Apr 13, 2026
Add .chloggen entry for PR open-telemetry#47512 and fix import ordering in generated_package_test.go per make gogci.
ogulcanaydogan
added a commit
to ogulcanaydogan/opentelemetry-collector-contrib
that referenced
this pull request
Apr 13, 2026
Add .chloggen entry for PR open-telemetry#47512 and fix import ordering in generated_package_test.go per make gogci.
ogulcanaydogan
added a commit
to ogulcanaydogan/opentelemetry-collector-contrib
that referenced
this pull request
Apr 13, 2026
Add .chloggen entry for PR open-telemetry#47512 and fix import ordering in generated_package_test.go per make gogci.
ogulcanaydogan
added a commit
to ogulcanaydogan/opentelemetry-collector-contrib
that referenced
this pull request
Apr 15, 2026
Add .chloggen entry for PR open-telemetry#47512 and fix import ordering in generated_package_test.go per make gogci.
AndrewCharlesHay
pushed a commit
to AndrewCharlesHay/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2026
… mdatagen (open-telemetry#47512) This PR migrates the `metricsgeneration.MatchAttributes` feature gate in `processor/metricsgenerationprocessor` from manual `featuregate.GlobalRegistry().MustRegister()` to `metadata.yaml` for mdatagen code generation, as part of open-telemetry#46116. **Changes:** - Added `feature_gates:` section to `metadata.yaml` - Ran `go generate ./...` to produce `internal/metadata/generated_feature_gates.go` and update `documentation.md` - Removed the manual `MustRegister` block from `processor.go`; updated the call site to use `metadata.MetricsgenerationMatchAttributesFeatureGate` - Updated `processor_test.go` to reference the generated gate variable - Removed the `forbidigo` lint exclusion for this package from `.golangci.yml` **Testing:** ``` go build ./... # passes go test ./... # ok github.com/open-telemetry/opentelemetry-collector-contrib/processor/metricsgenerationprocessor ```
ogulcanaydogan
added a commit
to ogulcanaydogan/opentelemetry-collector-contrib
that referenced
this pull request
Apr 24, 2026
Add .chloggen entry for PR open-telemetry#47512 and fix import ordering in generated_package_test.go per make gogci.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates the
metricsgeneration.MatchAttributesfeature gate inprocessor/metricsgenerationprocessorfrom manualfeaturegate.GlobalRegistry().MustRegister()tometadata.yamlfor mdatagen code generation, as part of #46116.Changes:
feature_gates:section tometadata.yamlgo generate ./...to produceinternal/metadata/generated_feature_gates.goand updatedocumentation.mdMustRegisterblock fromprocessor.go; updated the call site to usemetadata.MetricsgenerationMatchAttributesFeatureGateprocessor_test.goto reference the generated gate variableforbidigolint exclusion for this package from.golangci.ymlTesting: