Skip to content

[receiver/tcp_check] rename to tcp_check with deprecated alias tcpcheck#47507

Merged
codeboten merged 1 commit into
open-telemetry:mainfrom
nicknikolakakis:fix/45339-rename-tcp_check-receiver
May 8, 2026
Merged

[receiver/tcp_check] rename to tcp_check with deprecated alias tcpcheck#47507
codeboten merged 1 commit into
open-telemetry:mainfrom
nicknikolakakis:fix/45339-rename-tcp_check-receiver

Conversation

@nicknikolakakis

Copy link
Copy Markdown
Contributor

Part of:

Description

Renames the tcpcheck receiver type to tcp_check to match the snake_case naming convention established in open-telemetry/opentelemetry-collector#14208.

The previous type tcpcheck is preserved as a deprecated alias via xreceiver.WithDeprecatedTypeAlias, so existing user configurations remain functional and will log a deprecation warning at startup.

Metric names (tcpcheck.*) and the directory layout (receiver/tcpcheckreceiver) are intentionally unchanged to avoid user-facing breakage, matching the precedent set by other receiver renames under #45339 (e.g. #47505, #47369, #47370, #47291, #46750, #46729).

Link to tracking issue

Part of #45339

Testing

  • make generate regenerates internal/metadata/generated_status.go, generated_component_test.go, internal/metadata/config.schema.yaml, internal/metadata/generated_config.go, and documentation.md with the new type
  • go test ./... passes for the receiver (including TestLoadConfig/tcp_check after updating testdata/config.yaml)
  • make lint passes for the receiver
  • make chlog-validate passes
  • make gendistributions and make generate-chloggen-components produced the same diff as my edits

Documentation

  • Added a note at the top of the Configuration section in README.md explaining the rename and that the deprecated alias is still accepted
  • Updated the example config in README.md to use tcp_check:
  • Updated testdata/config.yaml to use the new receiver key

@codeboten codeboten left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please resolve the conflicts so we can get this merged

@nicknikolakakis nicknikolakakis force-pushed the fix/45339-rename-tcp_check-receiver branch from 560c67d to 87f82b5 Compare April 10, 2026 15:21
@nicknikolakakis

Copy link
Copy Markdown
Contributor Author

done.

@github-actions

Copy link
Copy Markdown
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions Bot added the Stale label Apr 25, 2026
@nicknikolakakis nicknikolakakis force-pushed the fix/45339-rename-tcp_check-receiver branch 3 times, most recently from 33a7239 to c679c1d Compare April 25, 2026 09:00
@github-actions github-actions Bot removed the Stale label Apr 26, 2026
…check`

Part of:
- open-telemetry#45339

Signed-off-by: Nick Nikolakakis <nonicked@protonmail.com>
@codeboten codeboten force-pushed the fix/45339-rename-tcp_check-receiver branch from c679c1d to 9365155 Compare May 8, 2026 18:10
@codeboten codeboten added the ready to merge Code review completed; ready to merge by maintainers label May 8, 2026
@codeboten codeboten merged commit 6b783b8 into open-telemetry:main May 8, 2026
207 of 209 checks passed
@otelbot

otelbot Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution @nicknikolakakis! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants