Skip to content

[chore] (processor/transformprocessor) migrate feature gates to metadata.yaml#47371

Merged
edmocosta merged 3 commits into
open-telemetry:mainfrom
agarvin-nr:agarvin/migrate-transform-processor-feature-gate
Apr 10, 2026
Merged

[chore] (processor/transformprocessor) migrate feature gates to metadata.yaml#47371
edmocosta merged 3 commits into
open-telemetry:mainfrom
agarvin-nr:agarvin/migrate-transform-processor-feature-gate

Conversation

@agarvin-nr
Copy link
Copy Markdown
Contributor

Description

  • Adds feature gate section to metadata.yaml with processor.transform.ConvertBetweenSumAndGaugeMetricContext and transform.flatten.logs
  • Adds reference URL and from_version feature gate information to processor.transform.ConvertBetweenSumAndGaugeMetricContext
  • Removes manual feature gate registration
  • Generated metadata

Link to tracking issue

Part of #46116

Testing

  • go build ./..., make gotest and make golint all pass

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Apr 3, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions Bot added the first-time contributor PRs made by new contributors label Apr 3, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 3, 2026

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better!

@github-actions github-actions Bot added the processor/transform Transform processor label Apr 3, 2026
Comment thread processor/transformprocessor/metadata.yaml Outdated
@agarvin-nr agarvin-nr force-pushed the agarvin/migrate-transform-processor-feature-gate branch from 61cd126 to 216c8e5 Compare April 6, 2026 16:23
@evan-bradley
Copy link
Copy Markdown
Contributor

Hi @agarvin-nr, thanks for helping us migrate this. The processor.transform.ConvertBetweenSumAndGaugeMetricContext feature gate is being removed here, so you can remove it from this PR since we'll no longer need it.

@agarvin-nr agarvin-nr force-pushed the agarvin/migrate-transform-processor-feature-gate branch from 371e8eb to 1ef287c Compare April 6, 2026 19:10
@agarvin-nr
Copy link
Copy Markdown
Contributor Author

Hi @agarvin-nr, thanks for helping us migrate this. The processor.transform.ConvertBetweenSumAndGaugeMetricContext feature gate is being removed here, so you can remove it from this PR since we'll no longer need it.

Hi @evan-bradley, I just removed it! While migrating other components, if I come across similar long-since-stable and unused feature gates, should I remove them as well or is it best to do so on a case-by-case basis?

@agarvin-nr agarvin-nr force-pushed the agarvin/migrate-transform-processor-feature-gate branch from 1ef287c to 7f70a8c Compare April 8, 2026 16:49
@edmocosta edmocosta merged commit 7d149db into open-telemetry:main Apr 10, 2026
189 of 192 checks passed
@otelbot
Copy link
Copy Markdown
Contributor

otelbot Bot commented Apr 10, 2026

Thank you for your contribution @agarvin-nr! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help.

@mx-psi
Copy link
Copy Markdown
Member

mx-psi commented Apr 10, 2026

@agarvin-nr It looks like there was anotehr feature gate that can be moved on this component, see

const defaultErrorModeIgnoreGateID = "processor.transform.defaultErrorModeIgnore"
var defaultErrorModeIgnoreFeatureGate = featuregate.GlobalRegistry().MustRegister(
defaultErrorModeIgnoreGateID,
featuregate.StageAlpha,
featuregate.WithRegisterDescription("Changes the default error_mode of the transform processor from propagate to ignore"),
featuregate.WithRegisterReferenceURL("https://github.com/open-telemetry/opentelemetry-collector-contrib/issues/47231"),
featuregate.WithRegisterFromVersion("v0.150.0"),
)

If you want to open a PR to remove this one I think that would allow us to remove this linter rule

- linters:
- forbidigo
path: processor/transformprocessor/
:)

@agarvin-nr
Copy link
Copy Markdown
Contributor Author

@mx-psi Sure thing! I just made a PR for it #47542 . I didn't know that linter rule was a thing for feature gates, that's cool! I went ahead and removed that exclusion as a part of the same PR, I hope that's alright.

mx-psi pushed a commit that referenced this pull request Apr 13, 2026
… to metadata.yaml and remove linting rule (#47542)

#### Description
* Migrates last feature gate (``) for `processor/transformprocessor` to
metadata.yaml
* Updates factory test to use new metadata feature gate ID
* Enables forbidigo linting rule for `processor/transformprocessor`
(rule forbids manual creation of feature gates)

#### Link to tracking issue
Part of #46116 
Follow-up for #47371 and #47506

#### Testing
`make lint` and `make test` pass.
AndrewCharlesHay pushed a commit to AndrewCharlesHay/opentelemetry-collector-contrib that referenced this pull request Apr 23, 2026
…ata.yaml (open-telemetry#47371)

#### Description
- Adds reference URL and `from_version` feature gate information to
`processor.transform.ConvertBetweenSumAndGaugeMetricContext`
- Removes manual feature gate registration
- Generated metadata

#### Link to tracking issue
Part of open-telemetry#46116

#### Testing
- `go build ./...`, `make gotest` and `make golint` all pass
AndrewCharlesHay pushed a commit to AndrewCharlesHay/opentelemetry-collector-contrib that referenced this pull request Apr 23, 2026
… to metadata.yaml and remove linting rule (open-telemetry#47542)

#### Description
* Migrates last feature gate (``) for `processor/transformprocessor` to
metadata.yaml
* Updates factory test to use new metadata feature gate ID
* Enables forbidigo linting rule for `processor/transformprocessor`
(rule forbids manual creation of feature gates)

#### Link to tracking issue
Part of open-telemetry#46116 
Follow-up for open-telemetry#47371 and open-telemetry#47506

#### Testing
`make lint` and `make test` pass.
gracewehner pushed a commit to gracewehner/opentelemetry-collector-contrib that referenced this pull request Apr 29, 2026
… to metadata.yaml and remove linting rule (open-telemetry#47542)

#### Description
* Migrates last feature gate (``) for `processor/transformprocessor` to
metadata.yaml
* Updates factory test to use new metadata feature gate ID
* Enables forbidigo linting rule for `processor/transformprocessor`
(rule forbids manual creation of feature gates)

#### Link to tracking issue
Part of open-telemetry#46116 
Follow-up for open-telemetry#47371 and open-telemetry#47506

#### Testing
`make lint` and `make test` pass.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first-time contributor PRs made by new contributors processor/transform Transform processor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants