[chore] (processor/transformprocessor) migrate feature gates to metadata.yaml#47371
Conversation
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
61cd126 to
216c8e5
Compare
|
Hi @agarvin-nr, thanks for helping us migrate this. The |
371e8eb to
1ef287c
Compare
Hi @evan-bradley, I just removed it! While migrating other components, if I come across similar long-since-stable and unused feature gates, should I remove them as well or is it best to do so on a case-by-case basis? |
1ef287c to
7f70a8c
Compare
|
Thank you for your contribution @agarvin-nr! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help. |
|
@agarvin-nr It looks like there was anotehr feature gate that can be moved on this component, see If you want to open a PR to remove this one I think that would allow us to remove this linter rule opentelemetry-collector-contrib/.golangci.yml Lines 206 to 208 in 208b7c0 |
… to metadata.yaml and remove linting rule (#47542) #### Description * Migrates last feature gate (``) for `processor/transformprocessor` to metadata.yaml * Updates factory test to use new metadata feature gate ID * Enables forbidigo linting rule for `processor/transformprocessor` (rule forbids manual creation of feature gates) #### Link to tracking issue Part of #46116 Follow-up for #47371 and #47506 #### Testing `make lint` and `make test` pass.
…ata.yaml (open-telemetry#47371) #### Description - Adds reference URL and `from_version` feature gate information to `processor.transform.ConvertBetweenSumAndGaugeMetricContext` - Removes manual feature gate registration - Generated metadata #### Link to tracking issue Part of open-telemetry#46116 #### Testing - `go build ./...`, `make gotest` and `make golint` all pass
… to metadata.yaml and remove linting rule (open-telemetry#47542) #### Description * Migrates last feature gate (``) for `processor/transformprocessor` to metadata.yaml * Updates factory test to use new metadata feature gate ID * Enables forbidigo linting rule for `processor/transformprocessor` (rule forbids manual creation of feature gates) #### Link to tracking issue Part of open-telemetry#46116 Follow-up for open-telemetry#47371 and open-telemetry#47506 #### Testing `make lint` and `make test` pass.
… to metadata.yaml and remove linting rule (open-telemetry#47542) #### Description * Migrates last feature gate (``) for `processor/transformprocessor` to metadata.yaml * Updates factory test to use new metadata feature gate ID * Enables forbidigo linting rule for `processor/transformprocessor` (rule forbids manual creation of feature gates) #### Link to tracking issue Part of open-telemetry#46116 Follow-up for open-telemetry#47371 and open-telemetry#47506 #### Testing `make lint` and `make test` pass.
Description
processor.transform.ConvertBetweenSumAndGaugeMetricContextandtransform.flatten.logsfrom_versionfeature gate information toprocessor.transform.ConvertBetweenSumAndGaugeMetricContextLink to tracking issue
Part of #46116
Testing
go build ./...,make gotestandmake golintall pass