[receiver/vcenter] add per-object fallback when perf batch query fails#47278
[receiver/vcenter] add per-object fallback when perf batch query fails#47278singhvibhanshu wants to merge 9 commits into
Conversation
Signed-off-by: singhvibhanshu <singhvibhanshu@hotmail.com>
|
@songy23, |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
/not stale |
|
This PR got merge conflicts. I'll fix them soon. |
# Conflicts: # receiver/vcenterreceiver/client.go # receiver/vcenterreceiver/client_test.go
Signed-off-by: singhvibhanshu <singhvibhanshu@hotmail.com>
Signed-off-by: singhvibhanshu <singhvibhanshu@hotmail.com>
|
@songy23, cc: @open-telemetry/collector-contrib-approvers |
|
This is fairly domain-specific, so will need to be reviewed by code owners. @schmikei @ishleenk17 PTAL |
| return nil, err | ||
| for _, obj := range batch { | ||
| singleSample, singleErr := vc.pm.SampleByName(ctx, spec, names, []vt.ManagedObjectReference{obj}) | ||
| if singleErr != nil { |
There was a problem hiding this comment.
Rather than discarding these errors, we should aggregate and log them (at a debug level?) to support fixing issues with the receiver moving forward.
| sample, err := vc.pm.SampleByName(ctx, spec, names, batch) | ||
| if err != nil { | ||
| return nil, err | ||
| for _, obj := range batch { |
There was a problem hiding this comment.
Rather than exploding the number of queries can we read the error, remove the failing metric(s), and try again as a batch?
5 participants
Follow-Up #47005