[chore] [receiver/postgresqlreceiver] update lib-pq from v1.10.9 to v1.12.3

[obs-gh-scottsolmonson]

Adding bug fixes and enhancements from lib-pq v1.12.0
https://github.com/lib/pq/blob/master/CHANGELOG.md

[linux-foundation-easycla]

[github-actions]

Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib.

Important reminders:

• Please review our Contributing Guidelines.
• Don't forget to sign the Contributor License Agreement (CLA) if you haven't already.

A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better!

[antonblock]

Are there any fixes in the new releases that apply to issues that have been reported? I'm only a bit cautious to upgrade because there have been several releases in the past months after none for ~3 years, and those had some regressions. I'd be in favor of waiting a bit to ensure everything's stable

[obs-gh-scottsolmonson]

Are there any fixes in the new releases that apply to issues that have been reported? I'm only a bit cautious to upgrade because there have been several releases in the past months after none for ~3 years, and those had some regressions. I'd be in favor of waiting a bit to ensure everything's stable

I understand the hesitation... the specific hard issue is this one (which effectively prevented most TLS-protected sessions in internal PKI environments from working): lib/pq#1267

I will investigate a clean backport for just that issue to the v1.10.9 branch of libpq as v1.10.10

EDIT ^^ backport to v.1.10.9 is non-trivial and there are many other compelling reasons for upgrade to newer libpq versions, so This Is The Way

[obs-gh-scottsolmonson]

@antonblock it has been over 2 weeks now since the go pq lib has stabilized. @braydonk anything further blocking this merge?

[atoulme]

Still need an approval from codeowners.

[obs-gh-scottsolmonson]

@atoulme if code owners are vacant I will take over- we can't have things like this sitting here for months+
cc @braydonk this is my formal request for full commit/owner perms on receiver/postgresqlreceiver

[bogdandrutu]

@atoulme has been a long time, since it is only dependency upgrade, let's merge.

[atoulme]

Are there any fixes in the new releases that apply to issues that have been reported? I'm only a bit cautious to upgrade because there have been several releases in the past months after none for ~3 years, and those had some regressions. I'd be in favor of waiting a bit to ensure everything's stable

I'm just going by @antonblock's feedback here. @antonblock @Caleb-Hurshman @ishleenk17 please weigh in as codeowners.

@obs-gh-scottsolmonson I will bring this up at the SIG meeting tonight.

[antonblock]

I agree this has been stable long enough without more regressions discovered, appreciate your patience

[songy23]

FYI 1.12.3 breaks tests: #47987 (comment)

you may want to try 1.12.0

[obs-gh-scottsolmonson]

FYI 1.12.3 breaks tests: #47987 (comment)

you may want to try 1.12.0

@songy23 that test looks bad:

=== FAIL: . TestPostgresqlDataSourceFieldsIntegrationMetrics (re-run 1) (63.97s) scraperint.go:114: Error Trace: /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/internal/coreinternal/scraperinttest/scraperint.go:114 /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/sqlqueryreceiver/integration_test.go:988 Error: Condition never satisfied Test: TestPostgresqlDataSourceFieldsIntegrationMetrics scraperint.go:94: resource "map[]": scope "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/sqlqueryreceiver": metric "genre.imdb": datapoint "map[genre:Action]": double value doesn't match expected: 7.650000, actual: 7.650000; resource "map[]": scope "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/sqlqueryreceiver": metric "genre.imdb": datapoint "map[genre:SciFi]": double value doesn't match expected: 8.200000, actual: 8.200000; resource "map[]": scope "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/sqlqueryreceiver": metric "f": datapoint "map[]": double value doesn't match expected: 4.300000, actual: 4.300000

^^ those double values appear to match

[obs-gh-scottsolmonson]

Local test does not fail:

`running go integration test TestIntegrationLogsTracking|TestPostgresqlIntegrationMetrics|TestOracleDBIntegrationMetrics|TestMysqlIntegrationMetrics|TestSQLServerIntegrationMetrics|TestSapASEIntegrationMetrics|TestPostgresqlDataSourceFieldsIntegrationMetrics in /Users/ssolmonsonint.snowflakecomputing.com/src/github/observeinc/scosol-opentelemetry-collector-contrib/receiver/sqlqueryreceiver
∅ internal
∅ internal/metadata (cached)
✓ . (cached)

=== Skipped
=== SKIP: . TestIntegrationLogsTracking/sqlserver (0.00s)
integration_test.go:164: Incompatible with arm64

=== SKIP: . TestIntegrationLogsTracking/oracle (0.00s)
integration_test.go:131: Skipping the test until #27577 is fixed

=== SKIP: . TestIntegrationLogsTracking/tds (0.00s)
integration_test.go:191: Skipping the test until #27577 is fixed

=== SKIP: . TestOracleDBIntegrationMetrics (0.00s)
integration_test.go:131: Skipping the test until #27577 is fixed

=== SKIP: . TestSQLServerIntegrationMetrics (0.00s)
integration_test.go:164: Incompatible with arm64

=== SKIP: . TestSapASEIntegrationMetrics (0.00s)
integration_test.go:191: Skipping the test until #27577 is fixed

DONE 18 tests, 6 skipped in 0.000s`

[obs-gh-scottsolmonson]

@songy23 Transitory failure? (nothing to do wth this receiver- seems access problem)

FAIL
exit status 1
FAIL github.com/open-telemetry/opentelemetry-collector-contrib/processor/k8sattributesprocessor 527.657s
Error: Process completed with exit code 1.

[atoulme]

CI passes - the e2e kubernetes tests are not related. I am going to risk a merge and we will see how main does.

[otelbot]

Thank you for your contribution @obs-gh-scottsolmonson! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help.

[songy23]

I see it, you only updated postgres receiver, while the test failure is in sql query receiver (with the same lib-pq version). This should be safe