[receiver/awss3] add tag_object_after_ingestion flag#46769
Merged
Conversation
tommyzli
force-pushed
the
s3-receiver-delete-obj
branch
from
4c2c9f0 to
e1ee372
Compare
tommyzli
force-pushed
the
s3-receiver-delete-obj
branch
from
e1ee372 to
c31a255
Compare
Contributor
|
Please cover in tests and docs the behavior if the receiver next consumer returns an error on Consume* calls. |
tommyzli
changed the title
Contributor
Author
|
@atoulme as we discussed I've updated the implementation to tagging objects instead of deleting them. I'll follow up with another PR after this to add a flag to skip tagged objects (cost was one reason for deleting, but the other is to prevent re-ingesting the same object multiple times, most applicable to non-sqs mode) |
tommyzli
force-pushed
the
s3-receiver-delete-obj
branch
from
828080e to
25c90a0
Compare
atoulme
reviewed
Mar 19, 2026
adcharre
reviewed
Mar 20, 2026
tommyzli
force-pushed
the
s3-receiver-delete-obj
branch
from
89fcd7e to
c5409bc
Compare
adcharre
approved these changes
Apr 1, 2026
atoulme
approved these changes
Apr 2, 2026
Contributor
|
Thank you for your contribution @tommyzli! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help. |
araiu
pushed a commit
to araiu/opentelemetry-collector-contrib
that referenced
this pull request
Apr 6, 2026
…46769) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description introduce a flag for the receiver to make a best-effort attempt to tag the objects it ingests. This is useful for cost management, as lifecycle policies can be used to delete tagged objects <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#46078 <!--Describe what testing was performed and which tests were added.--> #### Testing new unit tests <!--Please delete paragraphs that you did not use before submitting.-->
AndrewCharlesHay
pushed a commit
to AndrewCharlesHay/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2026
…46769) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description introduce a flag for the receiver to make a best-effort attempt to tag the objects it ingests. This is useful for cost management, as lifecycle policies can be used to delete tagged objects <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#46078 <!--Describe what testing was performed and which tests were added.--> #### Testing new unit tests <!--Please delete paragraphs that you did not use before submitting.-->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
introduce a flag for the receiver to make a best-effort attempt to tag the objects it ingests. This is useful for cost management, as lifecycle policies can be used to delete tagged objects
Link to tracking issue
Fixes #46078
Testing
new unit tests