[pkg/xstreamencoding] add unmarshaler adapters#46754
Merged
atoulme merged 1 commit intoMar 9, 2026
Merged
Conversation
Introduce adapters for plog.LogsUnmarshaler and pmetric.MetricsUnmarshaler which, on first call, read the entire stream into memory and invoke the unmarshaler. Subsequent calls return EOF. The offset is always the entire stream size in bytes, and if an offset is provided then that many bytes will discarded first. We also extract LogsDecoderFactory and MetricsDecoderFactory interfaces from LogsDecoderExtension and MetricsDecoderExtension in the encoding package.
axw
force-pushed
the
xstreamencoding-unmarshaler-adapter
branch
from
95b8a25 to
ecf1ef9
Compare
axw
requested review from
a team,
MovieStoreGuy,
VihasMakwana,
atoulme and
dmitryax
as code owners
paulojmdias
approved these changes
Mar 9, 2026
MichaelKatsoulis
approved these changes
Mar 9, 2026
atoulme
approved these changes
Mar 9, 2026
atoulme
left a comment
atoulme
left a comment
Contributor
There was a problem hiding this comment.
written by codeowner, merging.
ebrdarSplunk
pushed a commit
to ebrdarSplunk/opentelemetry-collector-contrib
that referenced
this pull request
Mar 9, 2026
#### Description Introduce adapters for plog.LogsUnmarshaler and pmetric.MetricsUnmarshaler which, on first call, read the entire stream into memory and invoke the unmarshaler. Subsequent calls return EOF. The offset is always the entire stream size in bytes, and if an offset is provided then that many bytes will discarded first. We also extract LogsDecoderFactory and MetricsDecoderFactory interfaces from LogsDecoderExtension and MetricsDecoderExtension in the encoding package. This PR was built with the assistance of Cursor. #### Link to tracking issue Relates to open-telemetry#46608 #### Testing Tests updated #### Documentation N/A
esosaoh
pushed a commit
to esosaoh/opentelemetry-collector-contrib
that referenced
this pull request
Mar 9, 2026
#### Description Introduce adapters for plog.LogsUnmarshaler and pmetric.MetricsUnmarshaler which, on first call, read the entire stream into memory and invoke the unmarshaler. Subsequent calls return EOF. The offset is always the entire stream size in bytes, and if an offset is provided then that many bytes will discarded first. We also extract LogsDecoderFactory and MetricsDecoderFactory interfaces from LogsDecoderExtension and MetricsDecoderExtension in the encoding package. This PR was built with the assistance of Cursor. #### Link to tracking issue Relates to open-telemetry#46608 #### Testing Tests updated #### Documentation N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduce adapters for plog.LogsUnmarshaler and pmetric.MetricsUnmarshaler which, on first call, read the entire stream into memory and invoke the unmarshaler. Subsequent calls return EOF.
The offset is always the entire stream size in bytes, and if an offset is provided then that many bytes will discarded first.
We also extract LogsDecoderFactory and MetricsDecoderFactory interfaces from LogsDecoderExtension and MetricsDecoderExtension in the encoding package.
This PR was built with the assistance of Cursor.
Link to tracking issue
Relates to #46608
Testing
Tests updated
Documentation
N/A