[processor/tailsampling] Add sample_on_root_span_only config#46610
Closed
singhvibhanshu wants to merge 6 commits into
Closed
[processor/tailsampling] Add sample_on_root_span_only config#46610singhvibhanshu wants to merge 6 commits into
singhvibhanshu wants to merge 6 commits into
Conversation
Signed-off-by: singhvibhanshu <singhvibhanshu@hotmail.com>
Signed-off-by: singhvibhanshu <singhvibhanshu@hotmail.com>
jmacd
approved these changes
Mar 4, 2026
d28b11f to
cb81b03
Compare
cb81b03 to
0f6a69d
Compare
Member
Author
|
Thanks for the approval @jmacd! |
Contributor
|
sorry, should we wait for discussion in #46600 to resolve first? |
Member
Author
|
yeah sure @carsonip! 👍 |
Member
Author
|
@carsonip, any updates on this? |
Contributor
|
@singhvibhanshu sorry for the delay, I was on holiday. The issue #46600 has been resolved via #46762 to allow for more flexibility. This sample_on_root_span_only config PR shouldn't be needed as this point since it only addresses a subset of problems compared to #46762 with minor differences. Please feel free to close this PR, or open a new issue to describe any problem you have with tail sampling processor. Thanks! |
Member
Author
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Adds a
sample_on_root_span_onlyconfiguration option to the tail sampling processor.When enabled, this allows the processor to make a sampling decision immediately upon receiving the root span, bypassing the decision wait time and reducing memory overhead for high-throughput scenarios.
Link to tracking Issue:
Resolves #46600
Testing:
Added a new unit test
TestSampleOnRootSpanOnlyinprocessor_test.goto verify that traces are exported immediately without waiting for thedecision_waitduration. Verified locally withmake gotest.Testing Result:
Documentation:
Added changelog entry.