[receiver/azure_functions] Introduce new component#46584
Conversation
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
|
Welcome, contributor! Thank you for your contribution to opentelemetry-collector-contrib. Important reminders:
A maintainer will review your pull request soon. Thank you for helping make OpenTelemetry better! |
|
/workflow-approve |
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
|
/workflow-approve |
constanca-m
left a comment
There was a problem hiding this comment.
Thanks Tanya! Looks great, just two comments
| | `http` | confighttp.ServerConfig | **Required.** HTTP server settings (e.g. `endpoint: :9090`). Typically use `FUNCTIONS_CUSTOMHANDLER_PORT`. | | ||
| | `auth` | component.ID | **Required.** Component ID of the extension that provides Azure authentication (e.g. token credential). | |
There was a problem hiding this comment.
If you already put required in the docs, maybe add it to the config validate already? In the skeleton PR, I usually add the validate implementation, but if you prefer to do it later, it is also fine. In that case, I would remove the required from this README
There was a problem hiding this comment.
I've added config validation
|
|
||
| type functionsReceiver struct{} | ||
|
|
||
| func newFunctionsReceiver(_ *Config, _ receiver.Settings, _ consumer.Logs) *functionsReceiver { |
There was a problem hiding this comment.
| func newFunctionsReceiver(_ *Config, _ receiver.Settings, _ consumer.Logs) *functionsReceiver { | |
| func newFunctionsReceiver(_ *Config, _ receiver.Settings, _ consumer.Logs) receiver.Receiver { |
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
zmoog
left a comment
There was a problem hiding this comment.
Added a few minor comments, but this LGTM!
| if cfg.Auth == (component.ID{}) { | ||
| errs = append(errs, errors.New("auth must be set")) | ||
| } |
There was a problem hiding this comment.
We can make this optional—or remove it for now—since the azureauth extension is needed for blob storage, something we're going to contribute a little later.
There was a problem hiding this comment.
good point! I made it optional
Co-authored-by: Maurizio Branca <maurizio.branca@elastic.co>
…resourcelogs_encoding in config tests Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
|
/workflow-approve |
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
|
/workflow-approve |
andrzej-stencel
left a comment
There was a problem hiding this comment.
Needs some more updates adding the underscore in name - those mentioned below and more.
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
|
Thank you for your contribution @tetianakravchenko! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey. If you are getting started contributing, you can also join the CNCF Slack channel #opentelemetry-new-contributors to ask for guidance and get help. |
Description
This change includes only overall structure (including factory), readme and proposed configuration for a new component.
Implementation will follow in future PRs.
Sponsored by @jmacd
Link to tracking issue
Part 1 of #43507
Testing
Initial tests were added
Documentation
Initial README added.