Skip to content

[receiver/activedirectoryds] enable attribute reaggregation#46408

Merged
andrzej-stencel merged 5 commits into
open-telemetry:mainfrom
ShaanveerS:enable-activedirectoryds
Apr 6, 2026
Merged

[receiver/activedirectoryds] enable attribute reaggregation#46408
andrzej-stencel merged 5 commits into
open-telemetry:mainfrom
ShaanveerS:enable-activedirectoryds

Conversation

@ShaanveerS
Copy link
Copy Markdown
Member

@ShaanveerS ShaanveerS commented Feb 25, 2026

Description

This PR enables dynamic metric configuration at runtime. This means that collector configuration files can now define a set of attributes for a metric that they would like to aggregate data by. This can be done on a per-metric basis for any metric attribute defined at a requirement level of recommended or below.

For more information about how reaggregation works please check out open-telemetry/opentelemetry-collector#14281.

Link to tracking issue

Fixes #46346

Testing

Unit tests are passing

@ShaanveerS ShaanveerS requested review from a team and pjanotti as code owners February 25, 2026 05:08
@ShaanveerS ShaanveerS force-pushed the enable-activedirectoryds branch 2 times, most recently from 5a9ec34 to 3027b4a Compare February 25, 2026 05:21
Enable re-aggregation support for the Active Directory DS receiver by:
- setting reaggregation_enabled: true
- defining requirement_level for all metric attributes
- regenerating metadata builders/tests/config fixtures

Signed-off-by: Shaanveer Singh <shaanver.singh@gmail.com>
@ShaanveerS ShaanveerS force-pushed the enable-activedirectoryds branch from 3027b4a to 8cabf29 Compare February 25, 2026 05:38
@dmitryax
Copy link
Copy Markdown
Member

@ShaanveerS please rebase

ShaanveerS and others added 4 commits March 12, 2026 06:35
Signed-off-by: Shaanveer Singh <shaanver.singh@gmail.com>
Signed-off-by: Shaanveer Singh <shaanver.singh@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 4, 2026

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions Bot added the Stale label Apr 4, 2026
@andrzej-stencel andrzej-stencel merged commit e78c9f1 into open-telemetry:main Apr 6, 2026
192 checks passed
emiliaFer pushed a commit to emiliaFer/opentelemetry-collector-contrib that referenced this pull request Apr 8, 2026
…emetry#46408)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This PR enables dynamic metric configuration at runtime. This means that
collector configuration files can now define a set of attributes for a
metric that they would like to aggregate data by. This can be done on a
per-metric basis for any metric attribute defined at a [requirement
level](open-telemetry/opentelemetry-collector#13913)
of `recommended` or below.

For more information about how reaggregation works please check out
open-telemetry/opentelemetry-collector#14281.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#46346

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Unit tests are passing

Signed-off-by: Shaanveer Singh <shaanver.singh@gmail.com>
AndrewCharlesHay pushed a commit to AndrewCharlesHay/opentelemetry-collector-contrib that referenced this pull request Apr 23, 2026
…emetry#46408)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
This PR enables dynamic metric configuration at runtime. This means that
collector configuration files can now define a set of attributes for a
metric that they would like to aggregate data by. This can be done on a
per-metric basis for any metric attribute defined at a [requirement
level](open-telemetry/opentelemetry-collector#13913)
of `recommended` or below.

For more information about how reaggregation works please check out
open-telemetry/opentelemetry-collector#14281.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes open-telemetry#46346

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Unit tests are passing

Signed-off-by: Shaanveer Singh <shaanver.singh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[receiver/activedirectoryds] Enable re-aggregation feature

6 participants