[receiver/activedirectoryds] enable attribute reaggregation#46408
Merged
andrzej-stencel merged 5 commits intoApr 6, 2026
Conversation
5a9ec34 to
3027b4a
Compare
Enable re-aggregation support for the Active Directory DS receiver by: - setting reaggregation_enabled: true - defining requirement_level for all metric attributes - regenerating metadata builders/tests/config fixtures Signed-off-by: Shaanveer Singh <shaanver.singh@gmail.com>
3027b4a to
8cabf29
Compare
paulojmdias
approved these changes
Feb 25, 2026
6 tasks
Member
|
@ShaanveerS please rebase |
Signed-off-by: Shaanveer Singh <shaanver.singh@gmail.com>
Signed-off-by: Shaanveer Singh <shaanver.singh@gmail.com>
Contributor
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
andrzej-stencel
approved these changes
Apr 6, 2026
emiliaFer
pushed a commit
to emiliaFer/opentelemetry-collector-contrib
that referenced
this pull request
Apr 8, 2026
…emetry#46408) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR enables dynamic metric configuration at runtime. This means that collector configuration files can now define a set of attributes for a metric that they would like to aggregate data by. This can be done on a per-metric basis for any metric attribute defined at a [requirement level](open-telemetry/opentelemetry-collector#13913) of `recommended` or below. For more information about how reaggregation works please check out open-telemetry/opentelemetry-collector#14281. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#46346 <!--Describe what testing was performed and which tests were added.--> #### Testing Unit tests are passing Signed-off-by: Shaanveer Singh <shaanver.singh@gmail.com>
AndrewCharlesHay
pushed a commit
to AndrewCharlesHay/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2026
…emetry#46408) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description This PR enables dynamic metric configuration at runtime. This means that collector configuration files can now define a set of attributes for a metric that they would like to aggregate data by. This can be done on a per-metric basis for any metric attribute defined at a [requirement level](open-telemetry/opentelemetry-collector#13913) of `recommended` or below. For more information about how reaggregation works please check out open-telemetry/opentelemetry-collector#14281. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes open-telemetry#46346 <!--Describe what testing was performed and which tests were added.--> #### Testing Unit tests are passing Signed-off-by: Shaanveer Singh <shaanver.singh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables dynamic metric configuration at runtime. This means that collector configuration files can now define a set of attributes for a metric that they would like to aggregate data by. This can be done on a per-metric basis for any metric attribute defined at a requirement level of
recommendedor below.For more information about how reaggregation works please check out open-telemetry/opentelemetry-collector#14281.
Link to tracking issue
Fixes #46346
Testing
Unit tests are passing