Skip to content

[chore] update pprofiles related tests#46320

Merged
songy23 merged 2 commits into
open-telemetry:mainfrom
florianl:pprofile-refs
Feb 24, 2026
Merged

[chore] update pprofiles related tests#46320
songy23 merged 2 commits into
open-telemetry:mainfrom
florianl:pprofile-refs

Conversation

@florianl
Copy link
Copy Markdown
Member

Description

open-telemetry/opentelemetry-proto#733 and open-telemetry/opentelemetry-collector#14546 are about to change how pprofiles work. As the input is changed in memory during the marshaling operation, it can no longer be used directly to validate the output.

FYI: @felixge

Link to tracking issue

Fixes

Testing

Documentation

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
Copy link
Copy Markdown
Member

@felixge felixge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Copy Markdown
Member

@paulojmdias paulojmdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songy23 songy23 merged commit 071efe7 into open-telemetry:main Feb 24, 2026
196 of 200 checks passed
avleentwilio pushed a commit to avleentwilio/opentelemetry-collector-contrib that referenced this pull request Apr 1, 2026
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

open-telemetry/opentelemetry-proto#733 and
open-telemetry/opentelemetry-collector#14546 are
about to change how pprofiles work. As the input is changed in memory
during the marshaling operation, it can no longer be used directly to
validate the output.

FYI: @felixge 

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->

---------

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants