Skip to content

[receiver/redfish] Follow semantic conventions for resource attributes#46236

Merged
andrzej-stencel merged 14 commits into
open-telemetry:mainfrom
khushijain21:redfish-semantic
Mar 11, 2026
Merged

[receiver/redfish] Follow semantic conventions for resource attributes#46236
andrzej-stencel merged 14 commits into
open-telemetry:mainfrom
khushijain21:redfish-semantic

Conversation

@khushijain21

@khushijain21 khushijain21 commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

Description

This PR deprecates removes resource attributes system.host_name and base_url in favor of host.name and url.full respectively as to follow the semantic conventions.

@khushijain21

khushijain21 commented Feb 20, 2026

Copy link
Copy Markdown
Contributor Author

I am not aware of any standard procedure to deprecate resource attributed and this PR only logs a warning about the change. Let me know if there is any other way

@khushijain21 khushijain21 marked this pull request as ready for review February 20, 2026 11:37
@khushijain21 khushijain21 requested a review from a team as a code owner February 20, 2026 11:37
@atoulme

atoulme commented Feb 22, 2026

Copy link
Copy Markdown
Contributor

Please look at the build

@andrzej-stencel andrzej-stencel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This component is in Development stability, you could easily just replace the attributes without any deprecation process. Up to you though!

Comment thread receiver/redfishreceiver/scraper.go Outdated
@khushijain21 khushijain21 marked this pull request as draft March 4, 2026 12:57
@khushijain21

Copy link
Copy Markdown
Contributor Author

This component is in Development stability, you could easily just replace the attributes without any deprecation process.

oh right okay - I think I'd rather replace the attributes. Thanks for pointing that out

@andrzej-stencel andrzej-stencel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, update the changelog entry please

Comment thread .chloggen/redfish-semantic-convention.yaml Outdated
Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
@khushijain21 khushijain21 marked this pull request as ready for review March 6, 2026 08:46
@khushijain21 khushijain21 marked this pull request as draft March 9, 2026 04:57
@khushijain21 khushijain21 marked this pull request as ready for review March 9, 2026 06:36
@khushijain21 khushijain21 marked this pull request as draft March 10, 2026 08:31
@khushijain21 khushijain21 marked this pull request as ready for review March 10, 2026 09:00
@andrzej-stencel andrzej-stencel added ready to merge Code review completed; ready to merge by maintainers and removed waiting-for-code-owners labels Mar 11, 2026
@andrzej-stencel andrzej-stencel merged commit f819301 into open-telemetry:main Mar 11, 2026
221 of 222 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Code review completed; ready to merge by maintainers receiver/redfish

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants