[chore] Use Make target for githubgen invocation#46151
Merged
Merged
Conversation
mx-psi
approved these changes
Feb 17, 2026
Member
mx-psi
left a comment
mx-psi
left a comment
There was a problem hiding this comment.
I don't understand the CI failure, this seems reasonable and I think we should merge it
Contributor
Author
|
I don't understand it either, but it appeared to be a simple fix, so I gave it a shot. |
edmocosta
approved these changes
Feb 17, 2026
paulojmdias
approved these changes
Feb 17, 2026
songy23
approved these changes
Feb 17, 2026
geekdave
pushed a commit
to oso-team/opentelemetry-collector-contrib
that referenced
this pull request
Feb 20, 2026
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Follow up from open-telemetry#45739 to use Make to invoke githubgen. I tried to clean things up a bit, but wasn't sure what should be used when and what makes sense to change. I've opened an issue to track this in case anyone would like to go deeper: open-telemetry#46150.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up from #45739 to use Make to invoke githubgen.
I tried to clean things up a bit, but wasn't sure what should be used when and what makes sense to change. I've opened an issue to track this in case anyone would like to go deeper: #46150.